Improve Open in Terminal in Mac

[sijad]

This also fixes #391

Tested in Mac OS X 10.11.4 (15E65)
With Terminal Version 2.6.1 (361.1) and iTerm2 Build 2.1.4

DEFAULT_TERMINAL_MAC also can be set as terminal.app or even terminal but I can't test if that works with older version of open command in previous Mac OS

[mention-bot]

By analyzing the blame information on this pull request, we identified @weinand and @egamma to be potential reviewers

[msftclas]

Hi @sijad, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

[Tyriar]

Going to adding to @joaomoreno as I don't have access to a mac/vm right now.

[Tyriar]

Getting an OS X VM setup so I can do it as @joaomoreno is out.

[weinand]

@sijad thanks for the PR.

Could you please provide some details about your improvements to 'Open in Terminal' on OS X.

I quickly reviewed the code and noticed that you have removed the AppleScripts that try to reuse the same terminal if it is not already running a command. Without that functionality, every 'Open in Terminal' creates a new Terminal window which quickly clutter the desktop.

[sijad]

@weinand that's true but applescript uses cd command and sometime it can be a little annoying
using open command is the preferred way to do this, I also did look into a few other editors and most of them uses same way to do this. but maybe using apple script is a better way, I really not sure either.

[weinand]

@sijad here is a first analysis of your PR. Please correct me if I'm wrong and add anything that is missing.

The PR:

• simplifies the implementation by using open to launch the Terminal.app instead of using multiple AppleScripts,
• makes the terminal application configurable through settings,
• adds a test.

The PR removes the following features:

• a user installed iTerm.app is no longer automatically used but must be configured manually in settings.
• 'Open in Terminal' does no longer reuse a non-busy terminal but always opens a new terminal. To get back the previous functionality a user has to install a custom application and configure it in the settings.

Verdict:
I think that the added configurability outweighs the loss of functionality of this PR.

[Tyriar]

@weinand as I understand it the main part of it is #5462 (OS X support for custom terminal launch settings #3495 )

[sijad]

@weinand you're right. As told applescript run cd and it will be saved in shell history. I just thought it's cleaner
I'm going to revert applescript

[weinand]

@sijad I'm not suggesting to revert the PR to use the AppleScript because that will complicate the launch settings: What do you specify in the setting instead of Terminal.app?
I think your PR is fine, I just wanted to understand what the PR does and how VS Code's existing behavior will change.

[sijad]

@weinand it's still possible to use AppleScript to lunch Terminal application

[weinand]

@sijad sure, instead of specifying Terminal.app in the settings, I can specify an AppleScript based application. But the AppleScript would not be the default and VS Code would not ship with it.

[Tyriar]

@weinand do you want to take this PR? I wouldn't have identified any issues with the AppleScript stuff.

[weinand]

@sijad today I've merged your PR into VS Code. Thanks a lot!
I could not accept the full PR because too many terminal related changes had occurred in the meantime. But I cherry picked your main commit and added three minor tweaks on top of that.