Introduce tree item highlights #61482
Conversation
|
@jrieken Please review the API changes |
src/vs/vscode.d.ts
Outdated
| /** | ||
| * Ranges in the label to highlight. | ||
| */ | ||
| highlights?: { start: number, end: number }[]; |
There was a problem hiding this comment.
We have been using tuples instead of objects so far, e.g valueSelection and ParameterInfo#label use [number,number]
src/vs/vscode.d.ts
Outdated
| /** | ||
| * Label describing the [Tree item](#TreeItem) | ||
| */ | ||
| export interface TreeItemLabel { |
There was a problem hiding this comment.
Having this as a separate type means, this will only work when the label is a string, right. Or putting it the other way, highlights will not work when the label is an Uri, right?
There was a problem hiding this comment.
Yes. You can only provide highlights to the labels you contribute. Otherwise it is not correct to allow providing highlights to computed labels.
There was a problem hiding this comment.
Yes, you can only have highlights for labels you contribute, otherwise it is not correct to allow them for computed labels.
|
@jrieken Updated |
src/vs/vscode.proposed.d.ts
Outdated
| /** | ||
| * Ranges in the label to highlight. | ||
| */ | ||
| highlights?: [number][number][]; |
There was a problem hiding this comment.
| highlights?: [number][number][]; | |
| highlights?: [number,number][]; |
There was a problem hiding this comment.
I think like that. Not even sure what [number][number][] means?
There was a problem hiding this comment.
I also do not know 😄 . It was a typo. Fixed.
|
@jrieken Fixed |
Introduce tree item highlights in Tree item api
Fixes #61313