-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add activeSignatureHelp to SignatureHelpContext #65440
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbvz
force-pushed
the
dev/mjbvz/activeSignatureHelp
branch
from
December 20, 2018 05:51
a75c49f
to
da752c8
Compare
We have two ways to do this:
|
For #33413 Adds the active `SignatureHelp` object (along with the active signature) to the `SignatureHelpContext`. Todo: - [ ] Tests are failing. Not part of this change directly but a logic error that this change revealed - How can we ensure that custom `SignatureHelp` objects are not lost when returned in the `SignatureHelpContext`
Makes sure custom SignatureHelp objects are correctly saved off in the `activeSignature` part of the context
mjbvz
force-pushed
the
dev/mjbvz/activeSignatureHelp
branch
from
January 7, 2019 21:47
da752c8
to
cddbf58
Compare
Merging in to proposed api |
joaomoreno
added a commit
that referenced
this pull request
Jan 8, 2019
This reverts commit 4a38520.
mjbvz
added a commit
that referenced
this pull request
Jan 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #33413
Adds the active
SignatureHelp
object (which has the correctactiveSignature
set) to theSignatureHelpContext
. This allows signature help providers to use theactiveSignature
info to take into account if the user has arrowed through signature help resultsTodo:
SignatureHelp
objects are not lost when returned through theSignatureHelpContext
?