Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode.workspace.fs #75882

Merged
merged 2 commits into from
Jun 24, 2019
Merged

vscode.workspace.fs #75882

merged 2 commits into from
Jun 24, 2019

Conversation

jrieken
Copy link
Member

@jrieken jrieken commented Jun 21, 2019

This PR is the work required for #48034

@jrieken jrieken self-assigned this Jun 21, 2019
@mjbvz
Copy link
Collaborator

mjbvz commented Jun 22, 2019

Nice work. If you are looking for a simple use case to test this new API, there's #50874. I think it should be as simple as switching out the calls to openDocument with direct calls to the proposed VS Code fs api

@jrieken
Copy link
Member Author

jrieken commented Jun 24, 2019

I think it should be as simple as switching out the calls to openDocument with direct calls to the proposed

That would be cool. Current gaps are mostly around getting from an Unit8Array to string. We don't expose any of the encoding logic and one would need to re-invent that or we expose some of our encoding logic as API...

@jrieken jrieken added this to the June 2019 milestone Jun 24, 2019
@jrieken jrieken added api-proposal feature-request Request for new features or functionality labels Jun 24, 2019
@jrieken jrieken merged commit 320fffc into master Jun 24, 2019
@jrieken jrieken deleted the joh/fs branch June 24, 2019 12:57
@jrieken
Copy link
Member Author

jrieken commented Jun 24, 2019

merged this PR so that we have the proposal to play with

@arcanis arcanis mentioned this pull request Sep 30, 2019
Open
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jrieken jrieken

Labels
api-proposal feature-request Request for new features or functionality
Projects
None yet
Milestone
June 2019
Development

Successfully merging this pull request may close these issues.
2 participants
@jrieken @mjbvz