Adopt new tree in custom views #76407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: This is still missing auto expanding of nodes, a feature that doesn't yet exist in the new tree. Once the functionality is available I'll add it before merging. |
sandy081
approved these changes
Jul 8, 2019
| const resourceLabel = this.labels.create(container, { supportHighlights: true, donotSupportOcticons: true }); | ||
| DOM.addClass(resourceLabel.element, 'custom-view-tree-node-item-resourceLabel'); | ||
| const actionsContainer = DOM.append(resourceLabel.element, DOM.$('.actions')); | ||
| const actionsContainer = DOM.append(container, DOM.$('.actions')); |
There was a problem hiding this comment.
@alexr00 One minor question as asked before, is this change intentional? Why not use the same structure as before?
There was a problem hiding this comment.
It is needed to have the correct alignment of the actions. Appending to the resourceLabel.element causes the action buttons to be right up against the resource label, instead of nicely aligned to the right.
|
@alexr00 I had just one last comment otherwise LGTM |
|
Auto expand is still missing. I'm merging now to start getting selfhost bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63566