Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Octicons with Codicons #82729

Merged
merged 8 commits into from
Oct 17, 2019
Merged

Replace Octicons with Codicons #82729

merged 8 commits into from
Oct 17, 2019

Conversation

miguelsolorio
Copy link
Contributor

This replaces our use of Octicons with Codicons, which now contain all of our products icons + the new Octicons. There shouldn't be any visible changes as the icons should be the same.

Areas impacted:

@miguelsolorio miguelsolorio added the icons-product Issues for in-product icons label Oct 16, 2019
@miguelsolorio miguelsolorio added this to the October 2019 milestone Oct 16, 2019
@bpasero bpasero removed their assignment Oct 17, 2019
bpasero
bpasero approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@misolori I suggest you check via fulltext search where else we use "octicon":

image

Also from our build scripts in distro.

jrieken
jrieken reviewed Oct 17, 2019
View reviewed changes
build/gulpfile.editor.js Outdated Show resolved Hide resolved
alexdima
alexdima requested changes Oct 17, 2019
View reviewed changes
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change in gulpfile.editor to have the standalone editor ship icons...

build/gulpfile.editor.js Outdated Show resolved Hide resolved
@miguelsolorio miguelsolorio merged commit 33fb4fe into master Oct 17, 2019
@miguelsolorio miguelsolorio deleted the misolori/icon-font branch October 17, 2019 19:28
@benoitf benoitf mentioned this pull request Nov 26, 2019
Closed
@azatsarynnyy azatsarynnyy mentioned this pull request Jan 17, 2020
Closed
6 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexdima alexdima alexdima requested changes

@jrieken jrieken jrieken approved these changes

@bpasero bpasero bpasero approved these changes

Assignees

@miguelsolorio miguelsolorio

Labels
icons-product Issues for in-product icons
Projects
None yet
Milestone
October 2019
Development

Successfully merging this pull request may close these issues.
4 participants
@miguelsolorio @bpasero @jrieken @alexdima