Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ts/js deprecated support #97742

Merged
merged 17 commits into from
Jun 22, 2020
Merged

Add ts/js deprecated support #97742

merged 17 commits into from
Jun 22, 2020

Conversation

Kingwl
Copy link
Contributor

@Kingwl Kingwl commented May 13, 2020

@Kingwl Kingwl marked this pull request as draft May 13, 2020 18:04
@Kingwl Kingwl changed the title Add ts/js deprecated support [WIP] Add ts/js deprecated support May 13, 2020
@Kingwl Kingwl marked this pull request as ready for review May 19, 2020 15:03
@Kingwl Kingwl changed the title [WIP] Add ts/js deprecated support Add ts/js deprecated support Jun 19, 2020
@Kingwl
Copy link
Contributor Author

Kingwl commented Jun 19, 2020

Work at TypeScript side is complete.
Please take a look. Friendly ping @mjbvz

mjbvz
mjbvz approved these changes Jun 20, 2020
View reviewed changes
Copy link
Collaborator

@mjbvz mjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change @Kingwl and for the great work on TypeScript

@jrieken Can you please take a quick look at the changes in VS Code core. They look good to me but I want you to check them since I believe you implemented the deprecated apis

extensions/package.json Outdated Show resolved Hide resolved
@mjbvz mjbvz requested a review from jrieken June 20, 2020 00:00
jrieken
jrieken approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Kingwl
Copy link
Contributor Author

Kingwl commented Jun 22, 2020

Thanks for the review!

@mjbvz mjbvz added this to the June 2020 milestone Jun 22, 2020
@mjbvz mjbvz merged commit 9d6054c into microsoft:master Jun 22, 2020
@mjbvz
Copy link
Collaborator

mjbvz commented Jun 22, 2020

Thanks @Kingwl! This will be in the next VS Code insiders build and is scheduled to ship with VS Code 1.47 in early July

@Kingwl Kingwl deleted the ts-deprecated branch June 23, 2020 02:44
@Kingwl
Copy link
Contributor Author

Kingwl commented Jun 23, 2020

Glad to work on this.
Let me know if something wrong. Thanks!.

@gjsjohnmurray gjsjohnmurray mentioned this pull request Jun 23, 2020
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrieken jrieken jrieken approved these changes

@mjbvz mjbvz mjbvz approved these changes

Assignees

@mjbvz mjbvz

Labels
None yet
Projects
None yet
Milestone
June 2020
Development

Successfully merging this pull request may close these issues.
3 participants
@Kingwl @mjbvz @jrieken