Move IncludeSourceRevisionInInformationalVersion to directory.build.p…

…rops (#5166)
microsoft · Aug 5, 2024 · 082e5da · 082e5da
1 parent f26adda
commit 082e5da
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/azure-pipelines-official.yml b/azure-pipelines-official.yml
@@ -100,8 +100,6 @@ variables:
   - name: VisualStudioDropName
     value: Products/$(System.TeamProject)/$(Build.DefinitionName)/$(Build.SourceBranchName)/$(Build.BuildNumber)
   - name: _InternalBuildArgs
-    # IncludeSourceRevisionInInformationalVersion prevents ProductVersion (on file), and AssemblyInformationalVersion
-    # from appending +<commitId>, which breaks DTAAgent.
     value: /p:DotNetSignType=$(_SignType)
       /p:TeamName=$(_TeamName)
       /p:DotNetFinalVersionKind=$(_ReleaseVersionKind)
@@ -111,7 +109,6 @@ variables:
       /p:OfficialBuildId=$(BUILD.BUILDNUMBER)
       /p:VisualStudioDropName=$(VisualStudioDropName)
       /p:GenerateSbom=true
-      /p:IncludeSourceRevisionInInformationalVersion=false
 
 resources:
   repositories:

diff --git a/eng/Versions.props b/eng/Versions.props
@@ -8,6 +8,11 @@
         is trying to parse that version and will consider any version with more than 4 `.` in it as invalid.
     -->
     <SemanticVersioningV1>true</SemanticVersioningV1>
+    <!--
+      IncludeSourceRevisionInInformationalVersion prevents ProductVersion (on file), and AssemblyInformationalVersion
+      from appending +<commitId>, which breaks DTAAgent.
+    -->
+    <IncludeSourceRevisionInInformationalVersion>false</IncludeSourceRevisionInInformationalVersion>
     <VersionPrefix>17.12.0</VersionPrefix>
     <PreReleaseVersionLabel>preview</PreReleaseVersionLabel>
   </PropertyGroup>