Wait for Discovery to initialize before Cancelling it #5177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoRossignoli
approved these changes
Aug 13, 2024
|
I tested it via vstest console wrapper so test is possible, but it is quite flaky, so I would rather avoid it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because discovery intialization takes time until the populates the _currentDiscoveryRequest, and any call to CancelDiscovery in the meantime would just return, we block until the request is populated, and then cancel. This is workaround for race condition that happens when you issue Discovery and DiscoveryCancel quickly in succession.
Related issue
Fix https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1579525