TOKEN_PRIVILEGES

[kennykerr]

This struct is defined as follows:

typedef struct _TOKEN_PRIVILEGES {
    DWORD PrivilegeCount;
    LUID_AND_ATTRIBUTES Privileges[ANYSIZE_ARRAY];
} TOKEN_PRIVILEGES, *PTOKEN_PRIVILEGES;

However the metadata emits it as follows:

public struct TOKEN_PRIVILEGES
{
	public uint PrivilegeCount;
	public TOKEN_PRIVILEGES_PrivilegesFlags Privileges;
}

There are two main issues:

• How to deal with the trailing variable sized array.
• The type of the second field is incorrect.

[sotteson1]

@AArnott, the scraper thought the flags should go on the Privileges member of TOKEN_PRIVILEGES, but it should have gone on LUID_AND_ATTRIBUTES.Attributes. If you plan on re-running the docs enum scraper, maybe you need to add a hint or tell it not to scrape this page or something else.

As for the second issue, we've talked about adding an attribute in the metadata to arrays to indicate the arrays are variable length. @kennykerr, would that solution work for you?

[kennykerr]

Yes, an attribute sounds good - thanks!

[AArnott]

#266 tracks the attribution of variable-length arrays.
Yes, I expect to run the scraper at least once more. I'll copy this bug to track the issue in the scraper, assuming you'll fix the broken API in the meantime.
I took a look at the docs and I think you'd have to be a human or understand the underlying types to understand that the attributes enum does not apply to the field itself, and we had scoped the design of the scraper to not have to read the metadata in order to establish the type of the enum. Can you instead handle reading the json we emit and realizing the field is not a primitive that could legitimately back an enum? In fact, as the field should be a struct, how is it that you're defining the enum now anyways since c# won't let LUID_AND_ATTRIBUTES be the base type of an enum?

[sotteson1]

This has been fixed, but still need to do #266 to add the attribute to variable length arrays.