Fix 30 seconds delay issue #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharityKathure
changed the title
Closed
added 2 commits
August 28, 2023 10:41
CharityKathure
requested review from
iankingori,
bobsira,
profnandaa and
TinaMor
profnandaa
reviewed
Aug 29, 2023
profnandaa
previously approved these changes
Aug 29, 2023
TinaMor
reviewed
Aug 29, 2023
bobsira
approved these changes
Sep 1, 2023
TinaMor
approved these changes
Sep 4, 2023
CharityKathure
added a commit
that referenced
this pull request
Dec 7, 2023
* reduce file monitor wait time --------- Co-authored-by: Charity Kathure <ckathure@microsoft.com>
CharityKathure
added a commit
that referenced
this pull request
Dec 7, 2023
* identify the ProviderGuid failing with 1168 * Onboard repo to Secure Development Tools Azure DevOps (#152) * resolve c:// monitor fix merge conflicts * Fix 30 seconds delay issue (#156) * reduce file monitor wait time * resolve event log failure fix merge conflicts --------- Co-authored-by: Bob Sira <sbobfitz2@gmail.com> Co-authored-by: Tina Murimi <christine.murimi@gmail.com> Co-authored-by: Charity Kathure <ckathure@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The container output is 30 seconds behind the contents of the file causing problems when viewing the container output through Azure Log Analytics, as Log Analytics gets an inaccurate "Time-Generated" timestamp, making ordering in Log Analytics wrong, therefore making viewing the logs and troubleshooting confusing and very difficult.
Change/ Fix
Reduce waitable time from 30 seconds
Testing
Deploy the new binary after change
Run this query in log analytics:
ContainerLog | where ContainerID in ('58b89a9a51a97a77cb9e0bcf5326ce326bcfc422cf96655fc5fced1374f2e73f') | extend LoglineEntry = parse_json(LogEntry) | extend LogEntryDetails = parse_json(LoglineEntry.LogEntry) | extend LogSource = LoglineEntry.Source | extend InFileDate = case(LogSource contains "File", todatetime(substring(LogEntryDetails.Logline, 0, 19)), LogEntryDetails.Time) | project LogSource, TimeGenerated, InFileDate, TimeDifference = toint(datetime_diff('second',TimeGenerated, InFileDate)), LogEntryDetails, LogEntry | where InFileDate != "" and LogSource contains "File" | distinct TimeGenerated, InFileDate;Testing Results:
Log analytics timestamp shows no delay