Skip to content

[Fix] Bug 34: Monitor files at Windows root directory #203

[Fix] Bug 34: Monitor files at Windows root directory

[Fix] Bug 34: Monitor files at Windows root directory #203

GitHub Actions / cpplint completed Aug 18, 2023 in 1s

reviewdog [cpplint] report

reported by reviewdog 🐶

Findings (5)

LogMonitor/src/LogMonitor/FileMonitor/FileMonitorUtilities.cpp|7| Found C++ system header after other header. Should be: FileMonitorUtilities.h, c system, c++ system, other. [build/include_order] [4]
LogMonitor/src/LogMonitor/FileMonitor/FileMonitorUtilities.h|10| public: should be indented +1 space inside class final [whitespace/indent] [3]
LogMonitor/src/LogMonitor/FileMonitor/FileMonitorUtilities.h|28| private: should be indented +1 space inside class final [whitespace/indent] [3]
LogMonitor/src/LogMonitor/LogFileMonitor.cpp|7| Found C++ system header after other header. Should be: LogFileMonitor.h, c system, c++ system, other. [build/include_order] [4]
LogMonitor/src/LogMonitor/Utility.h|19| Add #include for map<> [build/include_what_you_use] [4]

Filtered Findings (118)

LogMonitor/src/LogMonitor/ConfigFileParser.cpp|6| Include the directory when naming header files [build/include_subdir] [4]
LogMonitor/src/LogMonitor/ConfigFileParser.cpp|151| Lines should be <= 120 characters long [whitespace/line_length] [2]
LogMonitor/src/LogMonitor/ConfigFileParser.cpp|174| Lines should be <= 120 characters long [whitespace/line_length] [2]
LogMonitor/src/LogMonitor/ConfigFileParser.cpp|179| Lines should be <= 120 characters long [whitespace/line_length] [2]
LogMonitor/src/LogMonitor/ConfigFileParser.cpp|193| Lines should be <= 120 characters long [whitespace/line_length] [2]
LogMonitor/src/LogMonitor/ConfigFileParser.cpp|280| Lines should be <= 120 characters long [whitespace/line_length] [2]
LogMonitor/src/LogMonitor/ConfigFileParser.cpp|297| Lines should be <= 120 characters long [whitespace/line_length] [2]
LogMonitor/src/LogMonitor/ConfigFileParser.cpp|347| Lines should be <= 120 characters long [whitespace/line_length] [2]
LogMonitor/src/LogMonitor/ConfigFileParser.cpp|364| Lines should be <= 120 characters long [whitespace/line_length] [2]
LogMonitor/src/LogMonitor/ConfigFileParser.cpp|379| Lines should be <= 120 characters long [whitespace/line_length] [2]
LogMonitor/src/LogMonitor/ConfigFileParser.cpp|390| Lines should be <= 120 characters long [whitespace/line_length] [2]
LogMonitor/src/LogMonitor/ConfigFileParser.cpp|467| Lines should be <= 120 characters long [whitespace/line_length] [2]
LogMonitor/src/LogMonitor/ConfigFileParser.cpp|546| Lines should be <= 120 characters long [whitespace/line_length] [2]
LogMonitor/src/LogMonitor/ConfigFileParser.cpp|607| Lines should be <= 120 characters long [whitespace/line_length] [2]
LogMonitor/src/LogMonitor/ConfigFileParser.cpp|625| Lines should be <= 120 characters long [whitespace/line_length] [2]
LogMonitor/src/LogMonitor/ConfigFileParser.cpp|643| Lines should be <= 120 characters long [whitespace/line_length] [2]
LogMonitor/src/LogMonitor/EtwMonitor.cpp|6| Include the directory when naming header files [build/include_subdir] [4]
LogMonitor/src/LogMonitor/EtwMonitor.cpp|78| Lines should be <= 120 characters long [whitespace/line_length] [2]
LogMonitor/src/LogMonitor/EtwMonitor.cpp|83| Lines should be <= 120 characters long [whitespace/line_length] [2]
LogMonitor/src/LogMonitor/EtwMonitor.cpp|98| Lines should be <= 120 characters long [whitespace/line_length] [2]
LogMonitor/src/LogMonitor/EtwMonitor.cpp|103| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
LogMonitor/src/LogMonitor/EtwMonitor.cpp|600| Lines should be <= 120 characters long [whitespace/line_length] [2]
LogMonitor/src/LogMonitor/EtwMonitor.cpp|771| If an else has a brace on one side, it should have it on both [readability/braces] [5]
LogMonitor/src/LogMonitor/EtwMonitor.cpp|801| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
LogMonitor/src/LogMonitor/EtwMonitor.cpp|6| LogMonitor/src/LogMonitor/EtwMonitor.cpp should include its header file LogMonitor/src/LogMonitor/EtwMonitor.h [build/include] [5]
LogMonitor/src/LogMonitor/EtwMonitor.h|32| public: should be indented +1 space inside class final [whitespace/indent] [3]
LogMonitor/src/LogMonitor/EtwMonitor.h|42| private: should be indented +1 space inside class final [whitespace/indent] [3]
LogMonitor/src/LogMonitor/EtwMonitor.h|26| Add #include for pair<> [build/include_what_you_use] [4]
LogMonitor/src/LogMonitor/EtwMonitor.h|71| Add #include for vector<> [build/include_what_you_use] [4]
LogMonitor/src/LogMonitor/EventMonitor.cpp|6| Include the directory when naming header files [build/include_subdir] [4]
LogMonitor/src/LogMonitor/EventMonitor.cpp|157| Do not use variable-length arrays. Use an appropriately named ('k' followed by CamelCase) compile-time constant for the size. [runtime/arrays] [1]
LogMonitor/src/LogMonitor/EventMonitor.cpp|194| Lines should be <= 120 characters long [whitespace/line_length] [2]
LogMonitor/src/LogMonitor/EventMonitor.cpp|233| Lines should be <= 120 characters long [whitespace/line_length] [2]
LogMonitor/src/LogMonitor/EventMonitor.cpp|556| Lines should be <= 120 characters long [whitespace/line_length] [2]
LogMonitor/src/LogMonitor/EventMonitor.cpp|6| LogMonitor/src/LogMonitor/EventMonitor.cpp should include its header file LogMonitor/src/LogMonitor/EventMonitor.h [build/include] [5]
LogMonitor/src/LogMonitor/EventMonitor.h|10| public: should be indented +1 space inside class final [whitespace/indent] [3]
LogMonitor/src/LogMonitor/EventMonitor.h|21| private: should be indented +1 space inside class final [whitespace/indent] [3]
LogMonitor/src/LogMonitor/EventMonitor.h|48| Add #include for vector<> [build/include_what_you_use] [4]
LogMonitor/src/LogMonitor/FileMonitor/FileMonitorUtilities.cpp|6| Include the directory when naming header files [build/include_subdir] [4]
LogMonitor/src/LogMonitor/FileMonitor/FileMonitorUtilities.cpp|6| LogMonitor/src/LogMonitor/FileMonitor/FileMonitorUtilities.cpp should include its header file LogMonitor/src/LogMonitor/FileMonitor/FileMonitorUtilities.h [build/include] [5]
LogMonitor/src/LogMonitor/JsonFileParser.cpp|6| Include the directory when naming header files [build/include_subdir] [4]
LogMonitor/src/LogMonitor/JsonFileParser.cpp|7| Found C++ system header after other header. Should be: JsonFileParser.h, c system, c++ system, other. [build/include_order] [4]
LogMonitor/src/LogMonitor/LogFileMonitor.cpp|6| Include the directory when naming header files [build/include_subdir] [4]
LogMonitor/src/LogMonitor/LogFileMonitor.cpp|492| Lines should be <= 120 characters long [whitespace/line_length] [2]
LogMonitor/src/LogMonitor/LogFileMonitor.cpp|623| Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3]
LogMonitor/src/LogMonitor/LogFileMonitor.cpp|774| Lines should be <= 120 characters long [whitespace/line_length] [2]
LogMonitor/src/LogMonitor/LogFileMonitor.cpp|848| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
LogMonitor/src/LogMonitor/LogFileMonitor.cpp|1002| Lines should be <= 120 characters long [whitespace/line_length] [2]
LogMonitor/src/LogMonitor/LogFileMonitor.cpp|1678| Lines should be <= 120 characters long [whitespace/line_length] [2]
LogMonitor/src/LogMonitor/LogFileMonitor.cpp|1689| If an else has a brace on one side, it should have it on both [readability/braces] [5]
LogMonitor/src/LogMonitor/LogFileMonitor.cpp|6| LogMonitor/src/LogMonitor/LogFileMonitor.cpp should include its header file LogMonitor/src/LogMonitor/LogFileMonitor.h [build/include] [5]
LogMonitor/src/LogMonitor/LogFileMonitor.h|57| public: should be indented +1 space inside class final [whitespace/indent] [3]
LogMonitor/src/LogMonitor/LogFileMonitor.h|69| private: should be indented +1 space inside class final [whitespace/indent] [3]
LogMonitor/src/LogMonitor/LogFileMonitor.h|140| Add #include for map<> [build/include_what_you_use] [4]
LogMonitor/src/LogMonitor/LogFileMonitor.h|142| Add #include for queue<> [build/include_what_you_use] [4]
LogMonitor/src/LogMonitor/LogFileMonitor.h|174| Add #include for pair<> [build/include_what_you_use] [4]
LogMonitor/src/LogMonitor/LogFileMonitor.h|174| Add #include for vector<> [build/include_what_you_use] [4]
LogMonitor/src/LogMonitor/LogFileMonitor.h|195| Add #include for shared_ptr<> [build/include_what_you_use] [4]
LogMonitor/src/LogMonitor/LogWriter.h|10| public: should be indented +1 space inside class final [whitespace/indent] [3]
LogMonitor/src/LogMonitor/LogWriter.h|29| private: should be indented +1 space inside class final [whitespace/indent] [3]
LogMonitor/src/LogMonitor/LogWriter.h|41| public : should be indented +1 space inside class final [whitespace/indent] [3]
LogMonitor/src/LogMonitor/Main.cpp|6| Include the directory when naming header files [build/include_subdir] [4]
LogMonitor/src/LogMonitor/Main.cpp|134| Lines should be <= 120 characters long [whitespace/line_length] [2]
LogMonitor/src/LogMonitor/Main.cpp|194| Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3]
LogMonitor/src/LogMonitor/Parser/JsonFileParser.h|10| public: should be indented +1 space inside class JsonFileParser [whitespace/indent] [3]
LogMonitor/src/LogMonitor/Parser/JsonFileParser.h|21| Single-parameter constructors should be marked explicit. [runtime/explicit] [5]
LogMonitor/src/LogMonitor/Parser/JsonFileParser.h|58| private: should be indented +1 space inside class JsonFileParser [whitespace/indent] [3]
LogMonitor/src/LogMonitor/Parser/LoggerSettings.h|153| public: should be indented +1 space inside class LogSource [whitespace/indent] [3]
LogMonitor/src/LogMonitor/Parser/LoggerSettings.h|194| public: should be indented +1 space inside class SourceEventLog [whitespace/indent] [3]
LogMonitor/src/LogMonitor/Parser/LoggerSettings.h|246| public: should be indented +1 space inside class SourceFile [whitespace/indent] [3]
LogMonitor/src/LogMonitor/Parser/LoggerSettings.h|310| public: should be indented +1 space inside class ETWProvider [whitespace/indent] [3]
LogMonitor/src/LogMonitor/Parser/LoggerSettings.h|364| public: should be indented +1 space inside class SourceETW [whitespace/indent] [3]
LogMonitor/src/LogMonitor/Parser/LoggerSettings.h|407| Add #include for shared_ptr<> [build/include_what_you_use] [4]
LogMonitor/src/LogMonitor/Parser/LoggerSettings.h|407| Add #include for vector<> [build/include_what_you_use] [4]
LogMonitor/src/LogMonitor/ProcessMonitor.cpp|6| Include the directory when naming header files [build/include_subdir] [4]
LogMonitor/src/LogMonitor/ProcessMonitor.cpp|176| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
LogMonitor/src/LogMonitor/ProcessMonitor.cpp|197| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
LogMonitor/src/LogMonitor/ProcessMonitor.cpp|210| If an else has a brace on one side, it should have it on both [readability/braces] [5]
LogMonitor/src/LogMonitor/ProcessMonitor.cpp|214| If an else has a brace on one side, it should have it on both [readability/braces] [5]
LogMonitor/src/LogMonitor/ProcessMonitor.cpp|218| If an else has a brace on one side, it should have it on both [readability/braces] [5]
LogMonitor/src/LogMonitor/ProcessMonitor.cpp|222| If an else has a brace on one side, it should have it on both [readability/braces] [5]
LogMonitor/src/LogMonitor/ProcessMonitor.cpp|268| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
LogMonitor/src/LogMonitor/ProcessMonitor.cpp|271| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
LogMonitor/src/LogMonitor/ProcessMonitor.cpp|353| If an else has a brace on one side, it should have it on both [readability/braces] [5]
LogMonitor/src/LogMonitor/ProcessMonitor.cpp|6| LogMonitor/src/LogMonitor/ProcessMonitor.cpp should include its header file LogMonitor/src/LogMonitor/ProcessMonitor.h [build/include] [5]
LogMonitor/src/LogMonitor/Utility.cpp|6| Include the directory when naming header files [build/include_subdir] [4]
LogMonitor/src/LogMonitor/Utility.cpp|7| Found C++ system header after other header. Should be: Utility.h, c system, c++ system, other. [build/include_order] [4]
LogMonitor/src/LogMonitor/Utility.cpp|250| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
LogMonitor/src/LogMonitor/Utility.cpp|254| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
LogMonitor/src/LogMonitor/Utility.cpp|279| If an else has a brace on one side, it should have it on both [readability/braces] [5]
LogMonitor/src/LogMonitor/Utility.cpp|286| If an else has a brace on one side, it should have it on both [readability/braces] [5]
LogMonitor/src/LogMonitor/Utility.cpp|290| If an else has a brace on one side, it should have it on both [readability/braces] [5]
LogMonitor/src/LogMonitor/Utility.cpp|298| If an else has a brace on one side, it should have it on both [readability/braces] [5]
LogMonitor/src/LogMonitor/Utility.cpp|6| LogMonitor/src/LogMonitor/Utility.cpp should include its header file LogMonitor/src/LogMonitor/Utility.h [build/include] [5]
LogMonitor/src/LogMonitor/Utility.h|23| public: should be indented +1 space inside class final [whitespace/indent] [3]
LogMonitor/src/LogMonitor/pch.cpp|8| Include the directory when naming header files [build/include_subdir] [4]
LogMonitor/src/LogMonitor/pch.h|5| #ifndef header guard has wrong style, please use: LOGMONITOR_SRC_LOGMONITOR_PCH_H_ [build/header_guard] [5]
LogMonitor/src/LogMonitor/pch.h|59| #endif line should be "#endif // LOGMONITOR_SRC_LOGMONITOR_PCH_H_" [build/header_guard] [5]
LogMonitor/src/LogMonitor/pch.h|13| Found C system header after C++ system header. Should be: pch.h, c system, c++ system, other. [build/include_order] [4]
LogMonitor/src/LogMonitor/pch.h|14| Found C system header after C++ system header. Should be: pch.h, c system, c++ system, other. [build/include_order] [4]
LogMonitor/src/LogMonitor/pch.h|28| Found C system header after C++ system header. Should be: pch.h, c system, c++ system, other. [build/include_order] [4]
LogMonitor/src/LogMonitor/pch.h|29| Found C system header after C++ system header. Should be: pch.h, c system, c++ system, other. [build/include_order] [4]
LogMonitor/src/LogMonitor/pch.h|30| Found C system header after C++ system header. Should be: pch.h, c system, c++ system, other. [build/include_order] [4]
LogMonitor/src/LogMonitor/pch.h|31| Found C system header after C++ system header. Should be: pch.h, c system, c++ system, other. [build/include_order] [4]
LogMonitor/src/LogMonitor/pch.h|32| Found C system header after C++ system header. Should be: pch.h, c system, c++ system, other. [build/include_order] [4]
LogMonitor/src/LogMonitor/pch.h|33| Found C system header after C++ system header. Should be: pch.h, c system, c++ system, other. [build/include_order] [4]
LogMonitor/src/LogMonitor/pch.h|34| Found C system header after C++ system header. Should be: pch.h, c system, c++ system, other. [build/include_order] [4]
LogMonitor/src/LogMonitor/pch.h|35| Found C system header after C++ system header. Should be: pch.h, c system, c++ system, other. [build/include_order] [4]
LogMonitor/src/LogMonitor/pch.h|36| Found C system header after C++ system header. Should be: pch.h, c system, c++ system, other. [build/include_order] [4]
LogMonitor/src/LogMonitor/pch.h|38| Found C system header after C++ system header. Should be: pch.h, c system, c++ system, other. [build/include_order] [4]
LogMonitor/src/LogMonitor/pch.h|39| Found C system header after C++ system header. Should be: pch.h, c system, c++ system, other. [build/include_order] [4]
LogMonitor/src/LogMonitor/pch.h|45| Include the directory when naming header files [build/include_subdir] [4]
LogMonitor/src/LogMonitor/pch.h|46| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
LogMonitor/src/LogMonitor/pch.h|46| Found C system header after other header. Should be: pch.h, c system, c++ system, other. [build/include_order] [4]
LogMonitor/src/LogMonitor/pch.h|47| Found C system header after other header. Should be: pch.h, c system, c++ system, other. [build/include_order] [4]
LogMonitor/src/LogMonitor/resource.h|| No #ifndef header guard found, suggested CPP variable is: LOGMONITOR_SRC_LOGMONITOR_RESOURCE_H_ [build/header_guard] [5]
LogMonitor/src/LogMonitor/version.h|6| #ifndef header guard has wrong style, please use: LOGMONITOR_SRC_LOGMONITOR_VERSION_H_ [build/header_guard] [5]
LogMonitor/src/LogMonitor/version.h|16| #endif line should be "#endif // LOGMONITOR_SRC_LOGMONITOR_VERSION_H_" [build/header_guard] [5]

Annotations

Check warning on line 7 in LogMonitor/src/LogMonitor/FileMonitor/FileMonitorUtilities.cpp

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] LogMonitor/src/LogMonitor/FileMonitor/FileMonitorUtilities.cpp#L7

 Found C++ system header after other header. Should be: FileMonitorUtilities.h, c system, c++ system, other.  [build/include_order] [4]
Raw output
LogMonitor/src/LogMonitor/FileMonitor/FileMonitorUtilities.cpp:7:  Found C++ system header after other header. Should be: FileMonitorUtilities.h, c system, c++ system, other.  [build/include_order] [4]

Check warning on line 10 in LogMonitor/src/LogMonitor/FileMonitor/FileMonitorUtilities.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] LogMonitor/src/LogMonitor/FileMonitor/FileMonitorUtilities.h#L10

 public: should be indented +1 space inside class final  [whitespace/indent] [3]
Raw output
LogMonitor/src/LogMonitor/FileMonitor/FileMonitorUtilities.h:10:  public: should be indented +1 space inside class final  [whitespace/indent] [3]

Check warning on line 28 in LogMonitor/src/LogMonitor/FileMonitor/FileMonitorUtilities.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] LogMonitor/src/LogMonitor/FileMonitor/FileMonitorUtilities.h#L28

 private: should be indented +1 space inside class final  [whitespace/indent] [3]
Raw output
LogMonitor/src/LogMonitor/FileMonitor/FileMonitorUtilities.h:28:  private: should be indented +1 space inside class final  [whitespace/indent] [3]

Check warning on line 7 in LogMonitor/src/LogMonitor/LogFileMonitor.cpp

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] LogMonitor/src/LogMonitor/LogFileMonitor.cpp#L7

 Found C++ system header after other header. Should be: LogFileMonitor.h, c system, c++ system, other.  [build/include_order] [4]
Raw output
LogMonitor/src/LogMonitor/LogFileMonitor.cpp:7:  Found C++ system header after other header. Should be: LogFileMonitor.h, c system, c++ system, other.  [build/include_order] [4]

Check warning on line 19 in LogMonitor/src/LogMonitor/Utility.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] LogMonitor/src/LogMonitor/Utility.h#L19

 Add #include <map> for map<>  [build/include_what_you_use] [4]
Raw output
LogMonitor/src/LogMonitor/Utility.h:19:  Add #include <map> for map<>  [build/include_what_you_use] [4]