fix!: prevent linking of wdk libraries in tests that depend on wdk-sys
#118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGES: wdk_build::Config::configure_binary_build now returns a wdk_build::ConfigError instead of ().
wmmc88
force-pushed
the
fix-wdk-sys-ci-tests
branch
from
4c898cf to
499f6dc
Compare
wmmc88
changed the title
wdk-sys
rajavenms
previously approved these changes
Mar 5, 2024
rajavenms
approved these changes
Mar 5, 2024
hamzamust
approved these changes
Mar 6, 2024
wmmc88
added a commit
to wmmc88/windows-drivers-rs
that referenced
this pull request
Apr 8, 2024
* refactor: add lint exceptions for clippy::manual_c_str_literals and clippy::ref_as_ptr (microsoft#108) * ci: fix various pipeline breakages (nightly rustfmt bug, new nightly clippy lints, upstream winget dependency issue) (microsoft#117) * docs: fix `winget` llvm install command option (microsoft#115) Signed-off-by: Nicholas Rishel <rishel.nick@gmail.com> Co-authored-by: Melvin Wang <melvin.mc.wang@gmail.com> * fix!: prevent linking of wdk libraries in tests that depend on `wdk-sys` (microsoft#118) * refactor: change version bounds for `manual_c_str_literals` and `ref_as_ptr` clippy lints (microsoft#127) Signed-off-by: Melvin Wang <melvin.mc.wang@gmail.com> * Revert "Fix wdk sys ci tests (#23)" This reverts commit 165f26a. --------- Signed-off-by: Nicholas Rishel <rishel.nick@gmail.com> Signed-off-by: Melvin Wang <melvin.mc.wang@gmail.com> Co-authored-by: Nicholas Rishel <rishel.nick@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES: wdk_build::Config::configure_binary_build now returns a wdk_build::ConfigError instead of ().
This fixes execution of wdk-sys test in certain environments(ie. github windows runners) and should also allow crates that depend on
wdk-systo compile and run unit tests without linking against kernel libraries.