refactor: use a standardized workspace lint table #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmmc88
changed the title
workspace.lints table
auto-merge was automatically disabled
April 25, 2024 21:21
Pull request was converted to draft
hamzamust
approved these changes
Apr 30, 2024
ayodejiige
approved these changes
Apr 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the lints table feature has been released for the last 2 stable rust versions, I've migrated all of our linting configurations to use it so we can keep the configuration mostly in one place.
Unfortunately, due to rust-lang/cargo#13157, we cannot override workspace level lints yet, so several of the packages have locally defined lints in their Cargo manifest. This is still an improvement over before as now it applies at a package level instead of at the module level (and has caught several small issues)