Provide original encoding for string constants #2101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the win32 metadata captures original string encoding (microsoft/win32metadata#1008), we can use the
s!
andw!
macros to provide those string constants in their original encoding. This makes many string constants directly and efficiently usable as constants to pass to various Windows APIs that expect either Ansi or Wide null-terminated string literals. For example, you can now call the BCrypt APIs with the various string constants directly:I have also taken the liberty to separate the
w!
macro for wide string literals from WinRT support and now provide a dedicatedh!
macro for compile-timeHSTRING
support. This simplifies the vast majority of wide string literals that don't need WinRT support.