Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable hosted lib generation #2365

Merged
merged 15 commits into from
Mar 7, 2023
Merged

Enable hosted lib generation #2365

merged 15 commits into from
Mar 7, 2023

Conversation

kennykerr
Copy link
Collaborator

@kennykerr kennykerr commented Mar 7, 2023

The lib workflow now builds and uploads the libs for all targets. This can be used to update those targets without having to build them locally.

I’ve also added a GitHub action to centralize the environment adjustments needed to get Rust to work properly with the targets inside the GitHub VMs.

@kennykerr kennykerr changed the title Testing hosted lib generation Enable hosted lib generation Mar 7, 2023
@kennykerr
Copy link
Collaborator Author

01ce49f just calls an API that's recently been added and isn't covered by the stale GNU libs. Once that failure is confirmed I can push the libs generated by the hosted build.

@kennykerr
Copy link
Collaborator Author

It's not finding the llvm-dlltool in the path. Not sure where to find that. 🤔

@riverar
Copy link
Collaborator

riverar commented Mar 7, 2023

@kennykerr That's in C:\msys64\mingw64\bin on the runners. The environment steps put that into GITHUB_PATH but I'm not sure if that works across the new workflows you created.

@riverar
Copy link
Collaborator

riverar commented Mar 7, 2023

Looks like updating path via composite actions is indeed not really supported actions/runner#789.

This aligns with my experience with all of GitHub's shiny new workflow tools/modularity efforts. They are so enticing on paper but when you try to actually use them... 😊

@kennykerr kennykerr merged commit 443e735 into master Mar 7, 2023
@kennykerr kennykerr deleted the upload branch March 7, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants