Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check diff for all targets #2404

Merged
merged 3 commits into from
Mar 29, 2023
Merged

Check diff for all targets #2404

merged 3 commits into from
Mar 29, 2023

Conversation

kennykerr
Copy link
Collaborator

Now that #2402 has been fixed, here's hoping we can enable diff checks for all targets.

@riverar
Copy link
Collaborator

riverar commented Mar 29, 2023

So msvc is failing because unbeknownst to me, the linker is embedding its version number into the output. 14.35.32215 becomes 0E 00 | 23 00 | D7 7D. Let me go spelunking in the linker.

image

@riverar
Copy link
Collaborator

riverar commented Mar 29, 2023

Looks like it emits the version string in link.exe!CImplib::EmitImportDescriptor. Doesn't look like it's tied into the existing undocumented /Brepro; that would have been too easy.

@kennykerr kennykerr merged commit ec95c1e into master Mar 29, 2023
@kennykerr kennykerr deleted the lib-diff branch March 29, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants