Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak riddle arguments #2563

Merged
merged 3 commits into from
Jul 2, 2023
Merged

Tweak riddle arguments #2563

merged 3 commits into from
Jul 2, 2023

Conversation

riverar
Copy link
Collaborator

@riverar riverar commented Jul 1, 2023

Aligns riddle long form arguments with experiences found in other command line tooling.

Some prior art on short/long arg syntax:

@riverar riverar requested a review from kennykerr July 1, 2023 16:34
@ChrisDenton
Copy link
Collaborator

Hm, unless I'm missing it there doesn't seem to be any precedent for -@? That seems like the worst of both worlds, no? It's sigil soup and non-standard.

@riverar

This comment was marked as resolved.

@riverar riverar marked this pull request as draft July 1, 2023 20:21
@riverar
Copy link
Collaborator Author

riverar commented Jul 1, 2023

Dropped the short forms and restored --etc. Kept the long forms (with double hyphens).

@ChrisDenton
Copy link
Collaborator

I admit I don't otherwise have any strong preferences, so long as it's not too weird. Consistency would be great but unfortunately Windows command line tools are all over the place. Even relatively recent first party, developer focused tools can't quite seem to agree on a convention (e.g. vswhere and winget).

@riverar riverar marked this pull request as ready for review July 1, 2023 23:25
@kennykerr
Copy link
Collaborator

Yes I've not been overwhelmed by the consistency in command line tools either, so I've always just tried to find the simplest and most intuitive approach for my tools.

By the looks of it, this (final) commit only changes from a single - to a -- and otherwise leaves things as they were. I don't love it, but I recognize it is at least a little more in line with the Rust family of command line tools, so I think this is probably fine.

@riverar riverar merged commit fa7b524 into master Jul 2, 2023
47 checks passed
@riverar riverar deleted the rafael/riddle_args branch July 2, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants