Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Win32 return value code transformation #2790

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Adjust Win32 return value code transformation #2790

merged 2 commits into from
Jan 12, 2024

Conversation

kennykerr
Copy link
Collaborator

Many trialing Win32 parameters include a retval attribute indicating that languages should turn these parameters into a logical return value if possible. The trouble is that this attribute is not broadly applied, so windows-bindgen attempts to infer it in more cases. This inference is necessarily conservative to avoid producing invalid or inefficient transformations. I did however notice that APIs that explicitly include the retval attribute were being skipped due to the conservative heuristic, so this update just ensures that explicit retval parameters are always transformed. This simplifies the new Windows shell sample #2789.

@kennykerr kennykerr merged commit 78fbe6a into master Jan 12, 2024
65 checks passed
@kennykerr kennykerr deleted the retval branch January 12, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant