Adjust Win32 return value code transformation #2790
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many trialing Win32 parameters include a
retval
attribute indicating that languages should turn these parameters into a logical return value if possible. The trouble is that this attribute is not broadly applied, sowindows-bindgen
attempts to infer it in more cases. This inference is necessarily conservative to avoid producing invalid or inefficient transformations. I did however notice that APIs that explicitly include theretval
attribute were being skipped due to the conservative heuristic, so this update just ensures that explicitretval
parameters are always transformed. This simplifies the new Windows shell sample #2789.