Remove redundant target checks #2973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpaoliello
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
The more that I think about this, the more that I like it - initially I was hesitant since anybody who may have accidently depended on the wrong crate will now get a linker error, whereas before it would silently work. That said, someone may be depending on one of these and thinking it is doing something and not realizing that it is a no-op.
ChrisDenton
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test to see whether these checks are really necessary given that
windows-targetsshould already eliminate invalid target crate download and compilation.And the build seems to confirm this. So unless there are counter arguments, this seems like the way to go.