Fix handling of COM interfaces with same method name #3059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is common in COM interfaces for different interfaces to have methods that have the same name, especially for interface "versions" that extend the semantics of the underlying interfaces. For example, look at many of the inheritance relationships in COM interfaces in DirectWrite (IDWriteTextFormat, IDWriteTextFormat2, IDWriteTextFormat3, etc.) This fixes the handling of this situation. All that is necessary is to use the syntax which explicitly selects a specific trait, when invoking IFoo_Impl methods. This PR adds unit test coverage for this situation.
kennykerr
approved these changes
May 25, 2024
mati865
pushed a commit
to mati865/windows-rs
that referenced
this pull request
Jun 15, 2024
It is common in COM interfaces for different interfaces to have methods that have the same name, especially for interface "versions" that extend the semantics of the underlying interfaces. For example, look at many of the inheritance relationships in COM interfaces in DirectWrite (IDWriteTextFormat, IDWriteTextFormat2, IDWriteTextFormat3, etc.) This fixes the handling of this situation. All that is necessary is to use the syntax which explicitly selects a specific trait, when invoking IFoo_Impl methods. This PR adds unit test coverage for this situation. Co-authored-by: Arlie Davis <ardavis@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is common in COM interfaces for different interfaces to have methods that have the same name, especially for interface "versions" that extend the semantics of the underlying interfaces. For example, look at many of the inheritance relationships in COM interfaces in DirectWrite (IDWriteTextFormat, IDWriteTextFormat2, IDWriteTextFormat3, etc.)
This fixes the handling of this situation. All that is necessary is to use the syntax which explicitly selects a specific trait, when invoking IFoo_Impl methods. This PR adds unit test coverage for this situation.