Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CliWrap usage #110

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Fix CliWrap usage #110

merged 1 commit into from
Dec 13, 2021

Conversation

Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented Dec 2, 2021

result.StandardOutput and result.StandardError can never be null, so string.IsNullOrWhiteSpace(...) (or maybe string.IsNullOrEmpty(...) to be less greedy) is a better fit.

`result.StandardOutput` and `result.StandardError` can never be null, so `string.IsNullOrWhiteSpace(...)` (or maybe `string.IsNullOrEmpty(...)` to be less greedy) is a better fit.
@zachcarp zachcarp merged commit ffd4d4a into microsoft:main Dec 13, 2021
@Tyrrrz Tyrrrz deleted the patch-1 branch December 13, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants