-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Docs #1471
Update Docs #1471
Conversation
@check-spelling-bot ReportUnrecognized words, please review:
Previously acknowledged words that are now absentATL contosa contosainstaller Globals IInstalled mytoolTo accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands... in a clone of the git@github.com:vedantmgoyal2009/winget-cli.git repository
|
I deleted it because I think it is outdated and not used after the 1.0 schema came out. Should I revert that commit? |
OK, since that specification is no longer supported. |
@check-spelling-bot ReportUnrecognized words, please review:
Previously acknowledged words that are now absentATL contosa contosainstaller Globals IInstalled mytool px WSLTo accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands... in a clone of the git@github.com:vedantmgoyal2009/winget-cli.git repository
|
@denelon I have fixed the issue as lechacon suggested. I'm ready for review again 😃. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you convert that MP4 file to a gif? MP4s aren't autoplayed by GitHub (and probably not autoplayed by docs.microsoft.com either...)
Great call out @jedieaston. I don't think the tool was quite ready when that was written. |
@vedantmgoyal2009 Do you want to add a blurb about being able to use the wingetcreate utility, or go ahead and get this PR approved and merged? |
@check-spelling-bot ReportUnrecognized words, please review:
Previously acknowledged words that are now absentATL contosa contosainstaller Globals IInstalled mytool px WSLTo accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands... in a clone of the git@github.com:vedantmgoyal2009/winget-cli.git repository
|
@check-spelling-bot ReportUnrecognized words, please review:
Previously acknowledged words that are now absentATL contosa contosainstaller Globals IInstalled mytool px WSLTo accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands... in a clone of the git@github.com:vedantmgoyal2009/winget-cli.git repository
|
@denelon I have added a section about using the tools. Also, I have converted the |
@vedantmgoyal2009 the expect.txt still shows the new words at the bottom of the file rather than alphabetically inline. |
@denelon Really sorry for that. Your previous message got missed with |
I think you pressed the wrong button. Should I create another PR with your suggestions? |
@vedantmgoyal2009. I'm not really a fan of huge PRs. Smaller ones are far easier to validate and accept. This way at least the bulk of what you did is updated, and we can continue making incremental improvements. Documentation is one of the most valuable things a contributor can make on a project. Thanks for all of the hard work! Yes, please make another PR 😊 |
Microsoft Reviewers: Open in CodeFlow