Add diagnostics to the processor component #3087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msftrubengu
approved these changes
Mar 20, 2023
| } | ||
| catch (Exception ex) | ||
| { | ||
| this.OnDiagnostics(DiagnosticLevel.Error, ex.ToString()); |
There was a problem hiding this comment.
Do you know how much ToString outputs for a RuntimeException? If it doesn't include much from the ErrorRecord we should also log that. I found ScriptStackTrace to be really helpful.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
This change adds the same diagnostics event to the
IConfigurationSetProcessorFactoryas theConfigurationProcessoralready has. It also adds a property to control the minimum level of events, enabling filtering to be done at event publishing rather than consumption.All of the public facing methods in the processor component are enlightened to send any escaping exceptions to the diagnostics before letting them generate an error. Additionally, verbose logs are added throughout to enable a better understanding of what/when things are happening.
Validation
Manual runs, including with verbose logging enabled. Verified output in log file.
Microsoft Reviewers: Open in CodeFlow