Improve correlation for optimized search in rest source and improve general correlation by downloading manifests #3252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JohnMcPMS
previously approved these changes
May 18, 2023
| @@ -894,7 +894,7 @@ namespace AppInstaller::Repository | |||
|
|
|||
| bool operator==(const SystemReferenceString& other) const | |||
| { | |||
| return Field == other.Field && String1 == other.String1 && String2 == other.String2; | |||
| return Field == other.Field && Utility::CaseInsensitiveEquals(String1, other.String1) && Utility::CaseInsensitiveEquals(String2, other.String2); | |||
There was a problem hiding this comment.
Probably needs to be ICU case insensitive since it is arbitrary data.
There was a problem hiding this comment.
Or better yet, just FoldCase on construction and go back to ==.
JohnMcPMS
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests added. Manual validation that microsoft edge can now be successfully correlated.
Microsoft Reviewers: Open in CodeFlow