Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the experimental feature gating the use of pinning to make it a stable feature. Credit to @ryfu-msft for this piece
It also adds a missing check for an edge case that the tests check. It wasn't being hit before because the pinning feature wasn't enabled for that test. Specifically,
CompositeSource_NullAvailableVersion
checks that we don't fail if the available version of a package is null; the pinning feature added checking for the pins after search, and when doing that it would access the available version without checking if it existed. This shouldn't have that much of an effect on users since we always keep populate the available version/source when we have an available package in the composite.Microsoft Reviewers: Open in CodeFlow