Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pinning a stable feature #3315

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Conversation

florelis
Copy link
Member

@florelis florelis commented Jun 6, 2023

This removes the experimental feature gating the use of pinning to make it a stable feature. Credit to @ryfu-msft for this piece

It also adds a missing check for an edge case that the tests check. It wasn't being hit before because the pinning feature wasn't enabled for that test. Specifically, CompositeSource_NullAvailableVersion checks that we don't fail if the available version of a package is null; the pinning feature added checking for the pins after search, and when doing that it would access the available version without checking if it existed. This shouldn't have that much of an effect on users since we always keep populate the available version/source when we have an available package in the composite.

Microsoft Reviewers: Open in CodeFlow

@florelis florelis marked this pull request as ready for review June 6, 2023 18:22
@florelis florelis requested a review from a team as a code owner June 6, 2023 18:22
@florelis florelis merged commit 41e70ac into microsoft:master Jun 6, 2023
@florelis florelis deleted the stablePinning branch June 6, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants