Enable Microsoft.WinGet.Client arm64 support #4392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
JohnMcPMS
previously approved these changes
Apr 19, 2024
src/PowerShell/Microsoft.WinGet.Client.Engine/Helpers/OperationWithProgressBase.cs
Outdated
Show resolved
Hide resolved
|
If this fixes: The PR can close that issue. |
microsoft-github-policy-service
bot
added
the
Issue-Bug
yao-msft
approved these changes
Apr 19, 2024
2 tasks
msftrubengu
added a commit
to msftrubengu/winget-cli
that referenced
this pull request
Apr 23, 2024
This PR enables arm64 for the Microsoft.WinGet.Client module. There's an OS bug that causes an AV (see microsoft#4251 (comment)) in arm64 devices that was fixed in a newer Windows build. The AV message is just shown for PowerShell Core. In Windows PowerShell no error message is displayed but it won't display progress either. Regardless, the winget install/uninstall operation still happens as the progress is shown after we asked winget to install the app. The configuration module doesn't get affected by the OS bug, so there's no need to disable progress. To keep showing progress the module now looks at the OS version. If the processor architecture is arm64 and the OS version is lower than 10.0.26068.0 progress is disabled in the module. I verified manually on arm64 builds with and without the fix. Fixes microsoft#4169 ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/4392)
msftrubengu
added a commit
that referenced
this pull request
Apr 23, 2024
#4392 ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/4402)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables arm64 for the Microsoft.WinGet.Client module.
There's an OS bug that causes an AV (see #4251 (comment)) in arm64 devices that was fixed in a newer Windows build. The AV message is just shown for PowerShell Core. In Windows PowerShell no error message is displayed but it won't display progress either. Regardless, the winget install/uninstall operation still happens as the progress is shown after we asked winget to install the app. The configuration module doesn't get affected by the OS bug, so there's no need to disable progress.
To keep showing progress the module now looks at the OS version. If the processor architecture is arm64 and the OS version is lower than 10.0.26068.0 progress is disabled in the module.
I verified manually on arm64 builds with and without the fix.
Fixes #4169
Microsoft Reviewers: Open in CodeFlow