Use ContinueWith rather than finally for coroutine result types #4669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florelis
approved these changes
Jul 25, 2024
DavidObando
added a commit
to microsoft/devcenter-catalog
that referenced
this pull request
Jul 31, 2024
This mitigates the issue fixed by microsoft/winget-cli#4669 until that code is released.
DavidObando
added a commit
to microsoft/devcenter-catalog
that referenced
this pull request
Jul 31, 2024
This mitigates the issue fixed by microsoft/winget-cli#4669 until that code is released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When run in PowerShell with MTA (multi-threaded apartment) enabled, the
RunOnMTAmethods have an optimization to run directly rather than spinning up a new thread. This optimization used afinallyto callComplete, but aTaskwill be returned (and the finally executed) before the task is completed. This resulted in a completed collection and errors when attempting to add more messages to it.Change
Use
ContinueWithandExecuteSynchronouslyto effectively make afinallyfor theTaskresult object. Convert the existingfinallyto only callCompleteon exception.Validation
Manually confirmed the -MTA case with
InvokeandStart/Completecommand use cases.Microsoft Reviewers: Open in CodeFlow