Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send unit telemetry on success #4720

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Send unit telemetry on success #4720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45f38b6
Send unit telemetry on success
JohnMcPMS Aug 8, 2024
830a2cf
Fix unit test
JohnMcPMS Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...icrosoft.Management.Configuration.UnitTests/Tests/ConfigurationProcessorTelemetryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ public void Telemetry_NoUnitEventOnSuccess()

GetConfigurationUnitSettingsResult result = testObjects.Processor.GetUnitSettings(testObjects.Unit);

Assert.Empty(this.EventSink.Events);
Assert.Single(this.EventSink.Events);
Assert.Equal(TelemetryEvent.ConfigUnitRunName, this.EventSink.Events[0].Name);
}

/// <summary>
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.Management.Configuration/Telemetry/Telemetry.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,12 +263,12 @@ namespace winrt::Microsoft::Management::Configuration::implementation
std::string_view action,
const IConfigurationUnitResultInformation& resultInformation) const noexcept try
{
// We only want to send telemetry for failures of publicly available units.
if (!IsTelemetryEnabled() || SUCCEEDED(static_cast<int32_t>(resultInformation.ResultCode())))
if (!IsTelemetryEnabled())
{
return;
}

// We only want to send telemetry for publicly available units.
IConfigurationUnitProcessorDetails details = unit.Details();
if (!details || !details.IsPublic())
{
Expand Down
Loading