Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammatical issues in Bug Report.yml, and Update dependencies #4788

Merged
merged 20 commits into from
Sep 18, 2024
Merged

Fix grammatical issues in Bug Report.yml, and Update dependencies #4788

merged 20 commits into from
Sep 18, 2024

Conversation

skanda890
Copy link
Contributor

@skanda890 skanda890 commented Sep 4, 2024

Summary of the PR

Update dependencies and more.


Microsoft Reviewers: Open in CodeFlow

mend-bolt-for-github bot and others added 3 commits September 4, 2024 18:02
Co-authored-by: mend-bolt-for-github[bot] <42819689+mend-bolt-for-github[bot]@users.noreply.github.com>
@skanda890 skanda890 requested a review from a team as a code owner September 4, 2024 12:42

This comment has been minimized.

@skanda890 skanda890 changed the title Fix grammatical issues and Create .whitesource file Fix grammatical issues in README.md and some ISSUE_TEMPLATES, Create .whitesource file, and Update expect.txt Sep 4, 2024
@denelon
Copy link
Contributor

denelon commented Sep 4, 2024

I'll need to have an engineer check Mend Bolt out before merging this PR.

@skanda890
Copy link
Contributor Author

skanda890 commented Sep 4, 2024

URL for Mend Bolt:https://www.mend.io/free-developer-tools/bolt

@JohnMcPMS
Copy link
Member

We already have internal infrastructure that handles the same type of reporting that Mend Bolt appears to be doing, and it is required that we leverage it. I would prefer not to add a 3rd party action (mild risk) that does the same (no apparent gain).

@skanda890
Copy link
Contributor Author

skanda890 commented Sep 4, 2024

But after using Mend Bolt for some time with other apps like Mend Bolt, I feel like Mend Bolt is better and is the best out of all.

@skanda890 skanda890 changed the title Fix grammatical issues in README.md and some ISSUE_TEMPLATES, Create .whitesource file, and Update expect.txt Fix grammatical issues in README.md and some ISSUE_TEMPLATES, Create .whitesource file, Update Powershell version from 7.2.8 to 7.2.18 in src/Microsoft.Management.Configuration.UnitTests/Microsoft.Management.Configuration.UnitTests.csproj, and Update expect.txt Sep 4, 2024
@denelon
Copy link
Contributor

denelon commented Sep 4, 2024

@skanda890 I can appreciate the familiarity with other tools and the things they provide. Rather than adding another layer of complexity which comes with potential performance limitations (5 calls / day with Mind Bolt) and the potential for other complex interactions, I'd ask what Mind Bolt is doing that we're not doing with our internal tooling to see if we can cover differences that way.

Given the response from our engineering team, I would not merge this PR and add Mind Bolt.

@skanda890
Copy link
Contributor Author

What service do you use? If I get this I can compare the features between them.

@denelon
Copy link
Contributor

denelon commented Sep 5, 2024

It's an internal set of tools. They are designed to ensure we're complying with all of our company policies. The bigger question I'd ask is what value does the tool you proposed provide? Let's assume the software vulnerability detection is handled by the tooling we use today.

@skanda890
Copy link
Contributor Author

Okay, leave that, what about the other things?

…duce vulnerabilities (#3)

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-DOTNET-SYSTEMDATASQLCLIENT-6149433
- https://snyk.io/vuln/SNYK-DOTNET-SYSTEMFORMATSASN1-7443633

Co-authored-by: snyk-bot <snyk-bot@snyk.io>
@skanda890 skanda890 changed the title Fix grammatical issues in README.md and some ISSUE_TEMPLATES, Create .whitesource file, Update Powershell version from 7.2.8 to 7.2.18 in src/Microsoft.Management.Configuration.UnitTests/Microsoft.Management.Configuration.UnitTests.csproj, and Update expect.txt Fix grammatical issues in README.md and some ISSUE_TEMPLATES, Create .whitesource file, Update dependencies, and Update expect.txt Sep 6, 2024
@skanda890 skanda890 changed the title Fix grammatical issues in README.md and some ISSUE_TEMPLATES, Create .whitesource file, Update dependencies, and Update expect.txt Fix grammatical issues in README.md and some ISSUE_TEMPLATES, Update dependencies, and Update expect.txt Sep 6, 2024
@skanda890 skanda890 marked this pull request as draft September 6, 2024 04:58
@skanda890 skanda890 changed the title Fix grammatical issues in README.md and some ISSUE_TEMPLATES, Update dependencies, and Update expect.txt Fix grammatical issues in README.md and some ISSUE_TEMPLATES, and Update dependencies Sep 6, 2024
@skanda890 skanda890 marked this pull request as ready for review September 6, 2024 05:03
.github/ISSUE_TEMPLATE/Bug_Report.yml Outdated Show resolved Hide resolved
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback Issue needs attention from issue or PR author label Sep 6, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback Issue needs attention from issue or PR author label Sep 12, 2024
@skanda890 skanda890 marked this pull request as draft September 13, 2024 01:32
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback Issue needs attention from issue or PR author label Sep 13, 2024
@skanda890 skanda890 marked this pull request as ready for review September 13, 2024 01:38
@skanda890 skanda890 requested a review from yao-msft September 15, 2024 11:58
@yao-msft
Copy link
Contributor

/azp run

yao-msft
yao-msft previously approved these changes Sep 16, 2024
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@skanda890
Copy link
Contributor Author

@yao-msft, I have made some changes. Kindly review them.

Copy link
Contributor

@Trenly Trenly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes for Microsoft.Posershell.SDK should be a separate pull request. It is best to keep each pull request limited to a single set of similar changes instead of grouping multiple changes into a single PR

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback Issue needs attention from issue or PR author label Sep 17, 2024
@skanda890
Copy link
Contributor Author

skanda890 commented Sep 17, 2024

The changes for Microsoft.Posershell.SDK should be a separate pull request. It is best to keep each pull request limited to a single set of similar changes instead of grouping multiple changes into a single PR

To: @Trenly

🌟 Ode to My PR Mishap 🌟

Oh, tangled branches of my git tree,
How thou dost vex me with thy entwined changes!
Forgive me, dear reviewer, for my folly,
As I seek redemption in separate PRs.

Let each branch stand alone, proud and distinct,
Like constellations in the midnight sky.
And may our codebase sing harmoniously,
Free from the cacophony of tangled diffs.

@Trenly, grant me this chance—
To untangle my commits, like a patient weaver,
Crafting a quilt of elegance and clarity.

In this digital realm, where bits converge,
Let our apologies be sincere, our PRs pristine.

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback Issue needs attention from issue or PR author label Sep 17, 2024
@denelon
Copy link
Contributor

denelon commented Sep 17, 2024

This is the first PR poetry I've ever heard of!

@yao-msft yao-msft merged commit 90d0fba into microsoft:master Sep 18, 2024
3 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Attention Issue needs attention from Microsoft label Sep 18, 2024
@skanda890
Copy link
Contributor Author

Do you guys have any tips on where to contribute or any open repositories where I can contribute?

@denelon
Copy link
Contributor

denelon commented Sep 18, 2024

It really depends on what your "goal" is. It could be better to go a bit deeper into code on a smaller number of projects rather than to scatter across a larger number of projects. Every project is going to have its own community and set of standards. There are lots of different ways to contribute as well. Sometimes just doing work on documentation adds massive value, other times it might be fixing bugs or adding features. It just depends on why you're wanting to contribute.

@skanda890
Copy link
Contributor Author

skanda890 commented Sep 19, 2024

It really depends on what your "goal" is. It could be better to go a bit deeper into code on a smaller number of projects rather than to scatter across a larger number of projects. Every project is going to have its own community and set of standards. There are lots of different ways to contribute as well. Sometimes just doing work on documentation adds massive value, other times it might be fixing bugs or adding features. It just depends on why you're wanting to contribute.

My goal is just to contribute to an open repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants