-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to .NET 8 and PS SDK 7.4 #5078
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still see some 6.0.*
dependencies in the CG report. I also see one with 7.2.*
that seems related to PS. Are these supposed to still be there?
--- Component: ---
System.Diagnostics.EventLog 6.0.0 - NuGet
--- Found at: ---
/s/src/WinGetUtilInterop.UnitTests/WinGetUtilInterop.UnitTests.csproj
--- Component: ---
System.Security.AccessControl 6.0.1 - NuGet
--- Found at: ---
/s/src/Microsoft.Management.Configuration.Processor/Microsoft.Management.Configuration.Processor.csproj
/s/src/AppInstallerCLIE2ETests/AppInstallerCLIE2ETests.csproj
/s/src/Microsoft.Management.Configuration.UnitTests/Microsoft.Management.Configuration.UnitTests.csproj
--- Component: ---
Microsoft.PowerShell.MarkdownRender 7.2.1 - NuGet
--- Found at: ---
/s/src/Microsoft.Management.Configuration.Processor/Microsoft.Management.Configuration.Processor.csproj
/s/src/AppInstallerCLIE2ETests/AppInstallerCLIE2ETests.csproj
/s/src/Microsoft.Management.Configuration.UnitTests/Microsoft.Management.Configuration.UnitTests.csproj
<PackageReference Include="System.Formats.Asn1" Version="6.0.1" /> | ||
<PackageReference Include="System.IO.Packaging" Version="6.0.1" /> | ||
<PackageReference Include="System.Security.Cryptography.Pkcs" Version="6.0.4" /> | ||
<PackageReference Include="Microsoft.Windows.Compatibility" Version="6.0.8" /> | ||
<PackageReference Include="System.Security.Cryptography.Xml" Version="6.0.1" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing these are the ones we were manually updating due to CVEs? Maybe we should start marking them so that we know they can be removed after updating the root dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe so; I didn't trace the git history to confirm that.
The build was mad at me for having them, so I cut anything else that was System.*
and version 6.*
.
Included via
These are the maximum versions, included by the 7.4 SDK and targeting .NET Standard 2.0. |
Change
.NET 6 and PowerShell SDK 7.2 are no longer supported. This change updates the uses of the PowerShell SDK to 7.4 and all .NET 6 projects to .NET 8.
Validation
winget.exe configuration via the dev package and the PS modules locally.
The pipeline should cover the rest of the affected scenarios.
Microsoft Reviewers: Open in CodeFlow