Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: Microsoft.PowerShell version 7.3.6.0 #112103

Conversation

CoolPlayLin
Copy link
Contributor

Pull request has been created with Komac v1.9.0 🚀

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 112103 in repo microsoft/winget-pkgs

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jul 14, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Manifest-Validation-Error Manifest validation failed label Jul 14, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@CoolPlayLin
Copy link
Contributor Author

CoolPlayLin commented Jul 14, 2023

Please BLOCK THIS PR

The publisher appears they haven't added arm & arm64 architecture now, This PR shouldn't be merged before the architecture has been published

@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Jul 14, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Jul 14, 2023
@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Jul 14, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello CoolPlayLin,

The pull request encountered an internal error and has been assigned to a developer to investigate.

Template: msftbot/validationError/internalError

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jul 14, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Retry-1 flag to indicate retried label Jul 14, 2023
@stephengillie stephengillie added Blocking-Issue Manifest validation is blocked by a known issue. Validation-Completed Validation passed and removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jul 14, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) July 14, 2023 16:54
@microsoft-github-policy-service
Copy link
Contributor

CoolPlayLin,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@stephengillie
Copy link
Collaborator

What if: This PR has passed manual validation, and could be merged. This specific package would need approval too.

@stephengillie stephengillie removed their assignment Jul 14, 2023
@mdanish-kh
Copy link
Contributor

@stephengillie We can take this PR, it doesn't seem to be a blocking issue since the PowerShell team releases the MSIX after a few days of the initial publish of the release on GitHub. The msix are later added in a separate PR. cc @anamnavi to confirm this as well please

@anamnavi
Copy link
Contributor

you can approve this. I'll create a separate PR within the hour for the msix installers for this release.

UpgradeBehavior: install
Commands:
- pwsh
PackageFamilyName: Microsoft.PowerShell_8wekyb3d8bbwe
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PackageFamilyName: Microsoft.PowerShell_8wekyb3d8bbwe

Not needed now to avoid messing up package correlation, can be added later when msix are released

Comment on lines +30 to +75
ReleaseNotes: |-
Documentation and Help Content
- Update the link for getting started in README.md (#19947)
SHA256 Hashes of the release artifacts
- hashes.sha256
- 3ECBFCD55C66ECF3B7E04206
- powershell_7.3.6-1.deb_amd64.deb
- A2F17EABFF85841FBE6C9E57
- powershell-7.3.6-1.cm.x86_64.rpm
- DCAC341B13A34EC19EB6CF86
- powershell-7.3.6-1.rh.x86_64.rpm
- DDA0F189B43188FACDA6F1D4
- powershell-7.3.6-linux-alpine-x64.tar.gz
- 184DBEB80CF6C9057C0BFB5E
- powershell-7.3.6-linux-arm32.tar.gz
- 26E476F0F249DAB51A30797B
- powershell-7.3.6-linux-arm64.tar.gz
- 244CE4D22650BF4A4BD722C3
- powershell-7.3.6-linux-x64.tar.gz
- 96B5F03D0C3D56F9A2D8A5DC
- powershell-7.3.6-linux-x64-fxdependent.tar.gz
- F23E31A5BC3E65CA581BF9BE
- powershell-7.3.6-osx-arm64.pkg
- 515980B61C0F068A4915D1FD
- powershell-7.3.6-osx-arm64.tar.gz
- 0DA3B51D61ADFDB4E5ACB2AF
- powershell-7.3.6-osx-x64.pkg
- 5D62564767756527DE52D878
- powershell-7.3.6-osx-x64.tar.gz
- 6B04DC76C954CAEB25D39069
- PowerShell-7.3.6-win-arm32.zip
- 2ABA0B8905D8C9846F7B0457
- PowerShell-7.3.6-win-arm64.zip
- 5DDBA433BF68DB74F7D47026
- PowerShell-7.3.6-win-fxdependent.zip
- 031FC07CED5BC7CCDF5E6154
- PowerShell-7.3.6-win-fxdependentWinDesktop.zip
- D26C224D781BD3DB16E36F18
- PowerShell-7.3.6-win-x64.msi
- A22114C3B00D50CF7295D35E
- PowerShell-7.3.6-win-x64.zip
- 5D4D658D2F54B88F99BD01BA
- PowerShell-7.3.6-win-x86.msi
- 85252C77738D38CF28AA18EE
- PowerShell-7.3.6-win-x86.zip
- BFBB03711669CF047276D13D
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ReleaseNotes: |-
Documentation and Help Content
- Update the link for getting started in README.md (#19947)
SHA256 Hashes of the release artifacts
- hashes.sha256
- 3ECBFCD55C66ECF3B7E04206
- powershell_7.3.6-1.deb_amd64.deb
- A2F17EABFF85841FBE6C9E57
- powershell-7.3.6-1.cm.x86_64.rpm
- DCAC341B13A34EC19EB6CF86
- powershell-7.3.6-1.rh.x86_64.rpm
- DDA0F189B43188FACDA6F1D4
- powershell-7.3.6-linux-alpine-x64.tar.gz
- 184DBEB80CF6C9057C0BFB5E
- powershell-7.3.6-linux-arm32.tar.gz
- 26E476F0F249DAB51A30797B
- powershell-7.3.6-linux-arm64.tar.gz
- 244CE4D22650BF4A4BD722C3
- powershell-7.3.6-linux-x64.tar.gz
- 96B5F03D0C3D56F9A2D8A5DC
- powershell-7.3.6-linux-x64-fxdependent.tar.gz
- F23E31A5BC3E65CA581BF9BE
- powershell-7.3.6-osx-arm64.pkg
- 515980B61C0F068A4915D1FD
- powershell-7.3.6-osx-arm64.tar.gz
- 0DA3B51D61ADFDB4E5ACB2AF
- powershell-7.3.6-osx-x64.pkg
- 5D62564767756527DE52D878
- powershell-7.3.6-osx-x64.tar.gz
- 6B04DC76C954CAEB25D39069
- PowerShell-7.3.6-win-arm32.zip
- 2ABA0B8905D8C9846F7B0457
- PowerShell-7.3.6-win-arm64.zip
- 5DDBA433BF68DB74F7D47026
- PowerShell-7.3.6-win-fxdependent.zip
- 031FC07CED5BC7CCDF5E6154
- PowerShell-7.3.6-win-fxdependentWinDesktop.zip
- D26C224D781BD3DB16E36F18
- PowerShell-7.3.6-win-x64.msi
- A22114C3B00D50CF7295D35E
- PowerShell-7.3.6-win-x64.zip
- 5D4D658D2F54B88F99BD01BA
- PowerShell-7.3.6-win-x86.msi
- 85252C77738D38CF28AA18EE
- PowerShell-7.3.6-win-x86.zip
- BFBB03711669CF047276D13D
ReleaseNotes: |-
Build and Packaging Improvements
Bump .NET to 7.0.306
- Update Notices file
- Don't publish notice on failure because it prevents retry
- Bump .NET to 7.0.306 (#19945)
- Remove the property disabling optimization (#19952)
- Add ProductCode in registry for MSI install (#19951)
- Update variable used to bypass the blocking check for multiple NuGet feeds (#19953)
- Change System.Security.AccessControl preview version to stable version (#19931)
Documentation and Help Content
- Update the link for getting started in README.md (#19947)

InstallerType: msi
InstallerUrl: https://github.com/PowerShell/PowerShell/releases/download/v7.3.6/PowerShell-7.3.6-win-x64.msi
InstallerSha256: 758E130DC13708A72CEE29DB0B8EFD987376A4A4A22114C3B00D50CF7295D35E
ProductCode: '{420AE50D-8B07-4845-8592-3BECCD71DE80}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ProductCode: '{420AE50D-8B07-4845-8592-3BECCD71DE80}'
ProductCode: '{3E1D544C-E761-430F-B278-43E9FBFF0E4F}'

InstallerType: msi
InstallerUrl: https://github.com/PowerShell/PowerShell/releases/download/v7.3.6/PowerShell-7.3.6-win-x86.msi
InstallerSha256: 0D295F1AE6B6F0A5531AC33DF0A98126175312FC85252C77738D38CF28AA18EE
ProductCode: '{1A2F632A-216A-444E-9AC6-C35DD5BCAA70}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ProductCode: '{1A2F632A-216A-444E-9AC6-C35DD5BCAA70}'
ProductCode: '{02A236F6-A7AA-4B3C-81F7-1A1B781616E3}'

ReleaseDate: 2023-07-13
Installers:
- Architecture: x86
InstallerType: msi
Copy link
Contributor

@mdanish-kh mdanish-kh Jul 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
InstallerType: msi
InstallerType: wix

In some cases, WiX and MSI are not considered equal in upgrades, there's an issue over at the CLI for this microsoft/winget-cli#2565. We should stick to the installer type listed in previous manifests.

InstallerSha256: 0D295F1AE6B6F0A5531AC33DF0A98126175312FC85252C77738D38CF28AA18EE
ProductCode: '{1A2F632A-216A-444E-9AC6-C35DD5BCAA70}'
- Architecture: x64
InstallerType: msi
Copy link
Contributor

@mdanish-kh mdanish-kh Jul 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
InstallerType: msi
InstallerType: wix

In some cases, WiX and MSI are not considered equal in upgrades, there's an issue over at the CLI for this microsoft/winget-cli#2565. We should stick to the installer type listed in previous manifests.

@microsoft-github-policy-service
Copy link
Contributor

Hello @CoolPlayLin,

The package manager bot determined changes have been requested to your PR.

Template: msftbot/changesRequested

@anamnavi
Copy link
Contributor

@mdanish-kh if it's easier I can create the PR for this whole version (msi and msix). I just need 30 mins or so, just let me know if it would be better

@mdanish-kh
Copy link
Contributor

@mdanish-kh if it's easier I can create the PR for this whole version (msi and msix). I just need 30 mins or so, just let me know if it would be better

That sounds better, I'll close this in favor of the new one when you create it

@mdanish-kh
Copy link
Contributor

Close with reason: Replaced by #112154;

auto-merge was automatically disabled July 14, 2023 20:24

Pull request was closed

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Jul 14, 2023
@CoolPlayLin CoolPlayLin deleted the Microsoft.PowerShell-7.3.6.0-89B831E1E6ECDBC76B846AFB0FEA092928F1854E branch July 14, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking-Issue Manifest validation is blocked by a known issue. Retry-1 flag to indicate retried Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants