Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove beta version: SoftFever.OrcaSlicer #148918

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Apr 12, 2024

winget shows beta version as latest release which is wrong. Remove beta version.
Latest stable release is 2.0.0 by #147065

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

winget shows beta version as latest release which is wrong. Remove beta version.
@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Apr 12, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) April 12, 2024 18:03
@stephengillie
Copy link
Collaborator

@stephengillie
Copy link
Collaborator

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Apr 12, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 4a9a3e5 into microsoft:master Apr 12, 2024
8 checks passed
@stephengillie
Copy link
Collaborator

Hi @Rotzbua,

Should this be readded under a similar PackageIdentifier? Such SoftFever.OrcaSlicer.Beta or similar?

@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@Rotzbua
Copy link
Contributor Author

Rotzbua commented Apr 12, 2024

Hi @stephengillie ,
I already tested the identifier SoftFever.OrcaSlicer.Beta locally.
The problem is, that the beta version uses the version 2.0.0 and not the suggested 2.0.0-beta.

If I list the installed software with winget list SoftFever.OrcaSlicer.Beta then I get no results. If I search for winget list SoftFever.OrcaSlicer then I get a result. So the beta is detected as release 2.0.0.

I am right that the project has to use 2.0.0-beta for beta builds instead of 2.0.0?

@Rotzbua Rotzbua deleted the remove_beta_orcaslicer branch April 12, 2024 20:11
@stephengillie
Copy link
Collaborator

Ah, I misunderstood. I thought it could use the same PackageVersion: 2.0.0-beta as the manifest removed in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants