Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godot 3.3.2 #15806

Closed
wants to merge 2 commits into from
Closed

Godot 3.3.2 #15806

wants to merge 2 commits into from

Conversation

Avellea
Copy link

@Avellea Avellea commented Jun 2, 2021

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Latest stable release of Godot Engine without C# support.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the PullRequest-Error PR is Invalid label Jun 2, 2021
@ghost
Copy link

ghost commented Jun 2, 2021

Hello @DynamicDonkey,
The package manager bot determined there was an issue with the pull request. Make sure the manifest files are under the manifests\partition\publisher\appname\version directory. The partition of the path must be the first letter of the publisher in lower-case.

Example:
Path: manifests / m / Microsoft / WindowsTerminal / 1.6.10571.0 / WindowsTerminal.yaml

For details on the error, see the details link below in the build pipeline.

You may also try the Windows Package Manager Manifest Creator

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@KaranKad
Copy link
Contributor

KaranKad commented Jun 2, 2021

I think we should add it when winget supports extracting from a .zip file.

@Avellea
Copy link
Author

Avellea commented Jun 2, 2021

I think we should add it when winget supports extracting from a .zip file.

You think so? It could easily be repackaged into a self extracting 7zip archive or an inno installer like the issue here. I'll be happy to close this unresolved if some more opinions come in. :)

EDIT: Pretty sure it's going to fail SmartScreen anyway, displayed the warning on my PC.

@KaranKad
Copy link
Contributor

KaranKad commented Jun 2, 2021

There was discussion about moderation at #14621 and so the application should come from it's original source.

Edit - I had this application on my watch list as well but currently winget does not support .zip and for winget to be trustworthy download links should be from official source only.

@Avellea
Copy link
Author

Avellea commented Jun 2, 2021

Guess I'll go ahead and close this PR then, no sense in letting it run if its considered "untrustworthy". Hopefully winget gets .zip support soon!

@Avellea
Copy link
Author

Avellea commented Jun 2, 2021

Closing in response to #14621. Waiting for .zip support in winget.

@Avellea Avellea closed this Jun 2, 2021
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jun 2, 2021
@PodyNoo
Copy link

PodyNoo commented Jan 15, 2023

@Avellea maybe this could be re-opened since winget now supports .zip installation #140

@Avellea
Copy link
Author

Avellea commented Jan 15, 2023

Wow I completely forgot about this. I'll submit a new PR with updated versions and mono support later today, if nobody has yet. Thank you!

@Calinou
Copy link
Contributor

Calinou commented Jan 15, 2023

Note that pull requests referencing ZIP files won't be accepted until WinGet 1.4 has reached enough adoption among users: #87300

@sitiom
Copy link
Contributor

sitiom commented Jan 30, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants