Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Open-Shell 4.4.142 #1630

Closed
wants to merge 1 commit into from
Closed

Add Open-Shell 4.4.142 #1630

wants to merge 1 commit into from

Conversation

latere-a-latere
Copy link
Contributor

@latere-a-latere latere-a-latere commented Jun 5, 2020 •
edited
Loading

Previously named classicshell
Part of latere-a-latere#3

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Jun 5, 2020
@ghost
Copy link

ghost commented Jun 5, 2020

This submission has moved to manual review.

@ghost ghost assigned VenkatMasetty Jun 5, 2020
@KevinLaMS KevinLaMS added the Validation-Installation-Error Error installing application label Jun 20, 2020
@KevinLaMS
Copy link
Contributor

There are 2 issues with this.

  1. the silent switches should be /qn not S
  2. this only succeeds if the user runs as Admin. Winget does not have a good way to communicate that yet. This is an issue on the client
    No UAC prompt winget-cli#218
    [Roadmap Scenarios] User vs. System, default should be user to not require admin rights for the default execution  winget-cli#281
    Please make installation for current user/all users, consistent for all packages winget-cli#388

@ghost
Copy link

ghost commented Jun 20, 2020

MarNicGit The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

@ghost ghost added Needs: author feedback and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Jun 20, 2020
@ghost ghost added the No-Recent-Activity No activity has occurred on this work item for seven days. label Jun 27, 2020
@ghost
Copy link

ghost commented Jun 27, 2020

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@ghost ghost closed this Jul 4, 2020
@ghost ghost unassigned VenkatMasetty Jul 4, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
No-Recent-Activity No activity has occurred on this work item for seven days. Validation-Installation-Error Error installing application
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@latere-a-latere @wingetbot @KevinLaMS @VenkatMasetty