Microsoft.Git: update to 2.32.0.vfs.0.0

[ldennington]

Microsoft Reviewers: Open in CodeFlow

[wingetbot]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ghost]

Hello @ldennington,
The pull request encountered an internal error and has been assigned to a developer to investigate.

[KevinLaMS]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ItzLevvie]

The Control Panel displays the version as 2.32.0.0.0 and as Publisher as The Git Development Community:

Windows Package Manager requires the entires to match what's shown in Control Panel (for this particular manifest - that will exclude PackageName as updating it will conflict with the Git.Git package) so that other people can upgrade the application without being on a constant upgrade loop.

[ldennington]

The Control Panel displays the version as 2.32.0.0.0 and as Publisher as The Git Development Community:

Windows Package Manager requires the entires to match what's shown in Control Panel (for this particular manifest - that will exclude PackageName as updating it will conflict with the Git.Git package) so that other people can upgrade the application without being on a constant upgrade loop.

Sure, I'm fine with making the necessary changes. To be clear - are you just asking for an update of the PackageVersion field to align with what's shown in Control Panel, or are there additional fields that should be updated?

[ItzLevvie]

I'm asking for an update to the PackageVersion and Publisher fields to match what's shown in Control Panel so others can easily upgrade via winget upgrade.

[wingetbot]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ghost]

Hello @ldennington,
The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.0 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator Preview.

For details on the specific error, see the details link below in the build pipeline.

[wingetbot]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ghost]

Hello @msftbot[bot]!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[derrickstolee]

@ldennington We should remove these InstallerSwitches now that we've adjusted the installer defaults.

[ldennington]

Will do - I'm going to do a larger manifest update once mjcheetham/update-winget#124 merges and a new release of the update-winget task is cut. I will be sure to include at that time, and will manually make the update for now.

[ldennington]

Oh never mind - thought this was the new PR against one of the new versions. Will not manually update since it already merged 😁.

[derrickstolee]

The Control Panel displays the version as 2.32.0.0.0 and as Publisher as The Git Development Community:

Windows Package Manager requires the entires to match what's shown in Control Panel (for this particular manifest - that will exclude PackageName as updating it will conflict with the Git.Git package) so that other people can upgrade the application without being on a constant upgrade loop.

@ItzLevvie: We want to be very careful to differentiate this package from the "standard" one that is Git for Windows. This version includes custom changes created by Microsoft and GitHub. Can we change the publisher to "Microsoft" instead of "The Git Development Community"?

I also notice that the license is listed as "Copyright (C) Microsoft Corporation" but at least the Git code is LGPLv2. Perhaps some other pieces that we ship in the package are not (@dscho might know a few of these components).

I look forward to your advice here.

[dscho]

the Git code is LGPLv2

It's actually GPLv2. And yes, different components shipped together with Git have different licenses (git.exe does not link to them).

[ItzLevvie]

cc @derrickstolee: I believe you may have to update the publisher in the application to be Microsoft or Microsoft Corporation or something along those lines rather than changing it in the manifest itself.

This is what the documentation shows Note: With the 1.0 release of the Windows Package Manager, this name affects how packages from a source are mapped to Apps installed in Windows 10 via Add / Remove Programs (ARP). The best practice is to ensure this matches the ARP entry for the package when it has been installed. The impact is associated with winget upgrade and winget list. - from https://github.com/microsoft/winget-pkgs/blob/master/doc/manifest/schema/1.0.0/defaultLocale.md#publisher; which is why I suggested to change it.

The license can be changed to LGPLv2. It was Copyright (C) Microsoft Corporation because there wasn't a Copyright and CopyrightUrl field before the 1.0 release of Windows Package Manager, so it was put in License and LicenseUrl instead.

[derrickstolee]

cc @derrickstolee: I believe you may have to update the publisher in the application to be Microsoft or Microsoft Corporation or something along those lines rather than changing it in the manifest itself.

Ok, so there is something we are doing wrong in our bundling of the product, probably because of how it shares a lot of components with git-for-windows/git. We will look into that part on our side.