Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharkdp/bat/0.22.1 #95489

Closed
wants to merge 8 commits into from
Closed

Sharkdp/bat/0.22.1 #95489

wants to merge 8 commits into from

Conversation

neomax7
Copy link
Contributor

@neomax7 neomax7 commented Feb 3, 2023 •
edited
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Feb 3, 2023
@neomax7
Copy link
Contributor Author

neomax7 commented Feb 4, 2023

hello
the manifest validates and it installs on my laptop without an error.
is there anyway to check the reason why winget-svc-validation (installer validation) process failed here?
thanks in advance

@sitiom
Copy link
Contributor

sitiom commented Feb 4, 2023 •
edited
Loading

hello the manifest validates and it installs on my laptop without an error. is there anyway to check the reason why winget-svc-validation (installer validation) process failed here? thanks in advance

Just wait for a moderator to approve your PR manually. Do not keep closing and creating new ones (I see you already have created 16 closed PRs of the same thing).

@neomax7
Copy link
Contributor Author

neomax7 commented Feb 4, 2023

hello the manifest validates and it installs on my laptop without an error. is there anyway to check the reason why winget-svc-validation (installer validation) process failed here? thanks in advance

Just wait for a moderator to approve your PR manually. Do not keep closing and creating new ones (I see you already have created 16 closed PRs of the same thing).

okay, thanks I will wait.
my bad on closed PRs,
I did closed/opened them, trying to re-initiate validation pipeline.
and just for the note, its not same 16, it is 4 different packages.

@sitiom
Copy link
Contributor

sitiom commented Feb 4, 2023

I did closed/opened them, trying to re-initiate validation pipeline.

You can reopen the same PR without making a new one.

@neomax7
Copy link
Contributor Author

neomax7 commented Feb 4, 2023

I did closed/opened them, trying to re-initiate validation pipeline.

You can reopen the same PR without making a new one.

giphy

@stephengillie stephengillie removed the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Feb 6, 2023
@stephengillie
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Feb 6, 2023
@neomax7
Copy link
Contributor Author

neomax7 commented Feb 20, 2023

Hi, just checking on the progress

@sitiom
Copy link
Contributor

sitiom commented Feb 20, 2023 •
edited
Loading

@neomax7 Try retriggering the pipelines in your PRs

@neomax7
Copy link
Contributor Author

neomax7 commented Feb 20, 2023

@neomax7 Try retriggering the pipelines in your PRs

Hi Sitiom,
I am not sure, how to manually retrigger the pipeline,, could you give me a hand?

thank you

@sitiom
Copy link
Contributor

sitiom commented Feb 20, 2023 •
edited
Loading

Like I said before, try closing and reopening this PR (don't make a new one)

@neomax7 neomax7 closed this Feb 20, 2023
@neomax7 neomax7 reopened this Feb 20, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Executable-Error Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Feb 20, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Executable-Error Blocking-Issue Manifest validation is blocked by a known issue. Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Feb 20, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@neomax7
Copy link
Contributor Author

neomax7 commented Feb 20, 2023

Hi @neomax7,

The package installs normally, but requires Microsoft.VCRedist.2015+.x64 (or x86) to run: image

thank you sir, I just added missing dependencies ! :)

@stephengillie
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Feb 21, 2023
@stephengillie
Copy link
Collaborator

stephengillie commented Feb 21, 2023 •
edited
Loading

thank you sir, I just added missing dependencies ! :)

Unfortunately, dependency support is held up by

@Trenly
Copy link
Contributor

Trenly commented Feb 23, 2023

[Policy] Blocking-Issue

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback This needs a response from the author. Blocking-Issue Manifest validation is blocked by a known issue. and removed Needs-Author-Feedback This needs a response from the author. labels Feb 23, 2023
@sitiom sitiom mentioned this pull request Mar 1, 2023
Closed
@kritr-msft
Copy link

@stephengillie Just out of curiosity, I thought winget itself had a dependency on vcruntime140.dll ?
At least based on my efforts to use it within Windows Sandbox required me to install the vcredist package before winget.
https://github.com/microsoft/winget-pkgs/blob/master/Tools/SandboxTest.ps1

@Trenly
Copy link
Contributor

Trenly commented Mar 22, 2023

@stephengillie Just out of curiosity, I thought winget itself had a dependency on vcruntime140.dll ?
At least based on my efforts to use it within Windows Sandbox required me to install the vcredist package before winget.
https://github.com/microsoft/winget-pkgs/blob/master/Tools/SandboxTest.ps1

VC Redist and VC Libs are two separate things. WinGet is dependent upon the VCLibs UWP package, which is not the same as Microsoft.VCRedist.2015+.[x86 | x64]

sitiom
sitiom suggested changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@sitiom sitiom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@microsoft-github-policy-service
Copy link
Contributor

Hello @neomax7,

The package manager bot determined changes have been requested to your PR.

Template: msftbot/changesRequested

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Aug 30, 2023
@neomax7 neomax7 closed this Aug 30, 2023
@neomax7 neomax7 deleted the sharkdp/bat/0.22.1 branch August 30, 2023 22:31
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sitiom sitiom sitiom requested changes

Assignees

@neomax7 neomax7

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Blocking-Issue Manifest validation is blocked by a known issue. Dependencies Validation-Executable-Error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@neomax7 @wingetbot @sitiom @stephengillie @Trenly @kritr-msft @AmelBawa-msft