Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ErrorResponsesAsDefault to true for PowerShell Style #953

Closed
peombwa opened this issue Apr 22, 2022 · 0 comments · Fixed by #957
Closed

Set ErrorResponsesAsDefault to true for PowerShell Style #953

peombwa opened this issue Apr 22, 2022 · 0 comments · Fixed by #957
Assignees
@irvinesunday
Labels
type: bug Something isn't working

Comments

@peombwa
Copy link
Member

peombwa commented Apr 22, 2022

Describe the bug
The current OpenAPI defines error responses on error codes instead of default. This change breaks AutoREST, which expects default to contain the error responses.

microsoft/OpenAPI.NET.OData#167 added ErrorResponsesAsDefault, which defaults to true. Consider using this default to avoid breaking existing tooling that relies on default.

To Reproduce
Inspect the responses object of the current (v1.0.10-preview based) OpenAPI file.
image

Expected behavior
image

Additional Context
#928 is still blocking PowerShell from being able to test recent changes made OpenAPI.Net.Odata v1.0.10-preview.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irvinesunday irvinesunday

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removes convert setting ErrorResponsesAsDefault microsoftgraph/microsoft-graph-devx-api
2 participants
@peombwa @irvinesunday