Removes convert setting ErrorResponsesAsDefault
#957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having this setting set to false currently breaks PowerShell codegen
irvinesunday
requested review from
andrueastman,
baywet,
ddyett,
MIchaelMainer,
nikithauc,
zengin,
MaggieKimani1,
fey101,
adhiambovivian and
danielmbaluka
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
peombwa
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #953
This PR:
ErrorResponsesAsDefaultsetting set tofalsecurrently breaks PowerShell codegen. We need to delete this so as to revert it to its default value in the conversion lib.,true.OpenAPIServiceto have the convert settings configurable for the different styles is being tracked here: HaveOpenApiConvertSettingsconfigurable for each style #956.