-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor TS code snippet to interfaces #1008
Conversation
CodeSnippetsReflection.OpenAPI/CodeSnippetsReflection.OpenAPI.csproj
Outdated
Show resolved
Hide resolved
CodeSnippetsReflection.OpenAPI/LanguageGenerators/TypeScriptGenerator.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking in the changes, a couple of additional comments.
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
thanks for making the changes. I do have one more "discussion" point. |
@baywet Yes. That was the next step that I was thinking of. We can add all the changes to this PR for both Go and PowerShell, was afraid might be too large for 1 PR but I'm happy to add both to this |
I'd vote to go ahead with that change, which should also include CSharp and Java |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few minor comments.
|
||
namespace CodeSnippetsReflection.OpenAPI.Test | ||
{ | ||
public static class AssertUtil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TestsCommon
(my naming) in Raptor is bothering me for the same reason :)
I think we can call it AssertExtensions
in this case.
We have been waiting on this implementation for a while now to clear the TS tests. It would be nice if we can go ahead with the check-in and build other languages on top of this change gradually. |
Co-authored-by: Mustafa Zengin <muzengin@microsoft.com>
f8ab282
to
035fea4
Compare
Kudos, SonarCloud Quality Gate passed! |
Refactor TS snippet generation to use Models and Interfaces.
Also resolves the issues listed below
Resolves #1016
Resolves #1013
Resolves #1014
Resolves #1015
Resolves #1012
Resolves #1011
Resolves #985
Resolves #965
Resolves #966
Resolves #814
Resolves #964