Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Sort scopes list for the UI. #149

Merged
merged 6 commits into from
Jun 21, 2018
Merged

Sort scopes list for the UI. #149

merged 6 commits into from
Jun 21, 2018

Conversation

MIchaelMainer
Copy link
Contributor

Our UI list is getting a bit long. Past time for a sorted list.

#147 and #148

@MIchaelMainer
Copy link
Contributor Author

Sorting the elements in this UI:
image

Split headers on CRLF per rfc2822 using regex /[\r\n]+/
Get the header value by splitting on the first instance of ':' using regex /:(.+)/
Copy link
Contributor

@darrelmiller darrelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I am correct in assuming the changes to sample queries is an independent thing to the scopes sorting, we probably want to try and avoid combining multiple sets of changes into a single PR.

@MIchaelMainer MIchaelMainer merged commit 6fef8a3 into dev Jun 21, 2018
@MIchaelMainer MIchaelMainer deleted the sortScopes branch June 21, 2018 23:46
Copy link

@muthurathinam muthurathinam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good..!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants