Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init client with correct base URL when custom request adapter is used #174

Merged
merged 1 commit into from
Jun 18, 2023
Merged

Init client with correct base URL when custom request adapter is used #174

merged 1 commit into from
Jun 18, 2023

Conversation

Ndiritu
Copy link
Contributor

@Ndiritu Ndiritu commented Jun 16, 2023

@Ndiritu Ndiritu self-assigned this Jun 16, 2023
@Ndiritu Ndiritu requested a review from a team as a code owner June 16, 2023 11:07
MIchaelMainer
MIchaelMainer approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@MIchaelMainer MIchaelMainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ndiritu Ndiritu merged commit 501bec4 into dev Jun 18, 2023
@Ndiritu Ndiritu deleted the fix/wrong-base-url branch June 18, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MIchaelMainer MIchaelMainer MIchaelMainer approved these changes

Assignees

@Ndiritu Ndiritu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ndiritu @MIchaelMainer