adds inner error description #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baywet
requested review from
ddyett,
MIchaelMainer,
nikithauc,
peombwa and
zengin
as code owners
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
zengin
suggested changes
Jan 31, 2022
MIchaelMainer
requested changes
Feb 2, 2022
Co-authored-by: Michael Mainer <MIchaelMainer@users.noreply.github.com>
zengin
approved these changes
Feb 2, 2022
|
@zengin do you have any idea why the workflow is failing at this point? |
zengin
reviewed
Feb 2, 2022
Co-authored-by: Mustafa Zengin <muzengin@microsoft.com>
MIchaelMainer
approved these changes
Feb 2, 2022
|
@baywet now the error looks like on how the transform is applied. The rule removes the whole microsoft.graph namespace for some reason. |
|
Maybe the chose tag should wrap around the template one? (not in front of my computer right now) |
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
|
there, the issue was caused by two things:
|
zengin
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inserts a description for the inner error type as prepration work for Kiota.
We're not describing the error itself as it's brought in the conversion process by OData conventions.
related microsoft/kiota#411
related microsoft/OpenAPI.NET.OData#167
More reading https://docs.microsoft.com/en-us/graph/errors
(I believe the inner error description is partly wrong, as it doesn't inherit from error according to the odata spec)