Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support native platform Http handlers for Xamarin.iOS and Xamarin.Android #5

Merged
merged 10 commits into from
Jun 10, 2019

Conversation

peombwa
Copy link
Member

@peombwa peombwa commented May 31, 2019

This PR adds support for native http handler when targeting Xamarin.iOS (NSUrlSessionHandler) and Xamarin.Android (AndroidClientHandler).

Fixes #

  • #481 Use native HTTP client handlers for Xamarin.iOS and Xamarin.Android.
  • #482 Skip CompressionHandler when NSUrlSessionHandler is used as final handler.

Changes proposed in this pull request

  • Updates core SDK to target Xamarin.iOS10 and MonoAndroid70.
  • Adds preprocessor directives for Xamarin.iOS and Xamarin.Android that are used to wire up native http handlers for the respective platform.
  • Adds an internal RemoveHandler method to GraphClientFactory to simplify removal of a DelegatingHandler by type.
  • Updates unit tests.
  • Adds Native Xamarin.Android test runner project to run existing unit tests on Android.

Other links

@peombwa peombwa marked this pull request as ready for review June 4, 2019 22:38
MIchaelMainer
MIchaelMainer previously approved these changes Jun 6, 2019
Copy link
Contributor

@MIchaelMainer MIchaelMainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add release notes

MIchaelMainer
MIchaelMainer previously approved these changes Jun 7, 2019
ConnectionPoolManager = 0x00000080,
// Long Running Operation Handler
/// Long Running Operation Handler
LongRunnungOperationHandler = 0x00000100
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Suggested change
LongRunnungOperationHandler = 0x00000100
LongRunningOperationHandler = 0x00000100

darrelmiller
darrelmiller previously approved these changes Jun 10, 2019
@peombwa peombwa merged commit 1f0d0f1 into dev Jun 10, 2019
@peombwa peombwa deleted the po/xamarinNariveHttpHandler branch June 12, 2019 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants