-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support native platform Http handlers for Xamarin.iOS and Xamarin.Android #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MIchaelMainer
previously approved these changes
Jun 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add release notes
MIchaelMainer
previously approved these changes
Jun 7, 2019
ConnectionPoolManager = 0x00000080, | ||
// Long Running Operation Handler | ||
/// Long Running Operation Handler | ||
LongRunnungOperationHandler = 0x00000100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
Suggested change
LongRunnungOperationHandler = 0x00000100 | |
LongRunningOperationHandler = 0x00000100 |
darrelmiller
previously approved these changes
Jun 10, 2019
darrelmiller
approved these changes
Jun 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for native http handler when targeting Xamarin.iOS (
NSUrlSessionHandler
) and Xamarin.Android (AndroidClientHandler
).Fixes #
Changes proposed in this pull request
Xamarin.iOS10
andMonoAndroid70
.Xamarin.iOS
andXamarin.Android
that are used to wire up native http handlers for the respective platform.RemoveHandler
method toGraphClientFactory
to simplify removal of aDelegatingHandler
by type.Xamarin.Android
test runner project to run existing unit tests on Android.Other links
HttpClientHandler
when targeting Xamarin.iOS and Xamarin.Android Cannot download multiple OneDrive files concurrently since v.1.13.0-beta msgraph-sdk-dotnet#413.NSUrlSessionHandler
limitations NSUrlSessionHandler - using GZipStream causes IOException anaisbetts/ModernHttpClient#50 (comment).Xamarin.iOS
test runner project due code generation restriction imposed on the platform, thusMoq
based tests can't run.