chore: apply latest policy template

no actual policy changes being made yet
microsoftgraph · Jun 12, 2023 · 41203b8 · 41203b8
1 parent 10eaf4b
commit 41203b8
Showing 1 changed file with 23 additions and 13 deletions.
diff --git a/.github/policies/msgraph-sdk-dotnet-branch-protection.yml b/.github/policies/msgraph-sdk-dotnet-branch-protection.yml
@@ -9,8 +9,10 @@ resource: repository
 configuration:
   branchProtectionRules:
 
-  # The following GitHub PolicyService properties are not supported: whoCanDismissReviews and whoCanPush
   - branchNamePattern: master
+    # This branch pattern applies to the following branches as of 06/12/2023 10:31:13:
+    # master
+
     # Specifies whether this branch can be deleted. boolean
     allowsDeletions: false
     # Specifies whether forced pushes are allowed on this branch. boolean
@@ -19,28 +21,33 @@ configuration:
     dismissStaleReviews: true
     # Specifies whether admins can overwrite branch protection. boolean
     isAdminEnforced: false
-    # Specifies the number of pull request reviews before merging. int (0-6)
+    # Indicates whether "Require a pull request before merging" is enabled. boolean
+    requiresPullRequestBeforeMerging: true
+    # Specifies the number of pull request reviews before merging. int (0-6). Should be null/empty if PRs are not required
     requiredApprovingReviewsCount: 1
     # Require review from Code Owners. Requires requiredApprovingReviewsCount. boolean
     requireCodeOwnersReview: true
-    # Are commits required to be signed. boolean
+    # Are commits required to be signed. boolean. TODO: all contributors must have commit signing on local machines.
     requiresCommitSignatures: false
     # Are conversations required to be resolved before merging? boolean
     requiresConversationResolution: true
     # Are merge commits prohibited from being pushed to this branch. boolean
     requiresLinearHistory: false
-    # Requires requiresStrictStatusChecks. Values can be any string, but if the value does not correspond to any existing status check, the status check will be stuck on pending for status since nothing exists to push an actual status
+    # Required status checks to pass before merging. Values can be any string, but if the value does not correspond to any existing status check, the status check will be stuck on pending for status since nothing exists to push an actual status
     requiredStatusChecks:
     - build
     - license/cla
-    # The docs conflict. Are branches required to be up to date before merging. Or Require status checks to pass before merging
+    # Require branches to be up to date before merging. Requires requiredStatusChecks. boolean
     requiresStrictStatusChecks: true
-    # Restrict who can push to matching branches
+    # Indicates whether there are restrictions on who can push. boolean. Should be set with whoCanPush.
     restrictsPushes: false
-    # Restrict who can dismiss pull request reviews
+    # Restrict who can dismiss pull request reviews. boolean
     restrictsReviewDismissals: false
 
   - branchNamePattern: dev
+    # This branch pattern applies to the following branches as of 06/12/2023 10:31:13:
+    # dev
+
     # Specifies whether this branch can be deleted. boolean
     allowsDeletions: false
     # Specifies whether forced pushes are allowed on this branch. boolean
@@ -49,23 +56,26 @@ configuration:
     dismissStaleReviews: true
     # Specifies whether admins can overwrite branch protection. boolean
     isAdminEnforced: false
-    # Specifies the number of pull request reviews before merging. int (0-6)
+    # Indicates whether "Require a pull request before merging" is enabled. boolean
+    requiresPullRequestBeforeMerging: true
+    # Specifies the number of pull request reviews before merging. int (0-6). Should be null/empty if PRs are not required
     requiredApprovingReviewsCount: 1
     # Require review from Code Owners. Requires requiredApprovingReviewsCount. boolean
     requireCodeOwnersReview: true
-    # Are commits required to be signed. boolean
+    # Are commits required to be signed. boolean. TODO: all contributors must have commit signing on local machines.
     requiresCommitSignatures: false
     # Are conversations required to be resolved before merging? boolean
     requiresConversationResolution: true
     # Are merge commits prohibited from being pushed to this branch. boolean
     requiresLinearHistory: false
-    # Requires requiresStrictStatusChecks. Values can be any string, but if the value does not correspond to any existing status check, the status check will be stuck on pending for status since nothing exists to push an actual status
+    # Required status checks to pass before merging. Values can be any string, but if the value does not correspond to any existing status check, the status check will be stuck on pending for status since nothing exists to push an actual status
     requiredStatusChecks:
     - build
     - license/cla
-    # The docs conflict. Are branches required to be up to date before merging. Or Require status checks to pass before merging
+    # Require branches to be up to date before merging. Requires requiredStatusChecks. boolean
     requiresStrictStatusChecks: true
-    # Restrict who can push to matching branches
+    # Indicates whether there are restrictions on who can push. boolean. Should be set with whoCanPush.
     restrictsPushes: false
-    # Restrict who can dismiss pull request reviews
+    # Restrict who can dismiss pull request reviews. boolean
     restrictsReviewDismissals: false
+