Deprecate national cloud parameter in access token provider constructor #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ndiritu
force-pushed
the
fix/national-cloud
branch
from
6ea93b4 to
b71e68f
Compare
Ndiritu
changed the title
Ndiritu
changed the title
nationalCloud parameter in access token provider constructor
Ndiritu
changed the title
nationalCloud parameter in access token provider constructor
Ndiritu
changed the title
|
baywet
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We provided a
$nationalCloudconstructor parameter that is not bubbled up to the parent class.This PR marks this parameter as deprecated & tests that the static builder method works as expected.
related to microsoftgraph/msgraph-sdk-php#1625