Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated unwrap method in promises namespace #1248

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

Ndiritu
Copy link
Contributor

@Ndiritu Ndiritu commented May 30, 2023

Latest Guzzle client now supports Guzzle Promises v2 which deprecates calling unwrap() under the GuzzleHttp\Promise namespace in favour of unwrap() in the Utils namespace.

Adds guzzlehttp/promises version as a dev-dependency since we use it directly in the tests to prevent future deprecation failures.

This is blocking this week's generation -https://dev.azure.com/microsoftgraph/Graph%20Developer%20Experiences/_build/results?buildId=115854&view=logs&j=29aed401-fc9b-57ac-1f64-2375ad5c4825&t=c358aceb-1691-5ab4-29cb-fd16fd0dd51f&l=175

Microsoft Reviewers: Open in CodeFlow

@Ndiritu Ndiritu requested a review from a team as a code owner May 30, 2023 12:34
@Ndiritu Ndiritu self-assigned this May 30, 2023
@Ndiritu Ndiritu merged commit bf4035b into dev Jun 6, 2023
@Ndiritu Ndiritu deleted the fix/promise-unwrap branch June 6, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants