Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: capture initial branch policy settings #1257

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Conversation

MIchaelMainer
Copy link
Contributor

@MIchaelMainer MIchaelMainer commented Jun 12, 2023

Capture current policy state so that we can make versioned changes to branch protection policies. This will enable policy history, auditing, review, standardization, and templatization. We will update policy in later PR.

We can ignore the rule that states: At least one value under RequiredStatusChecks must be specified when RequiresStrictStatusChecks is true. or RequiresStrictStatusChecks must be true when specifying RequiredStatusChecks. This is getting removed. This is getting removed.

This branch protection policy will not take effect until https://github.com/microsoftgraph/.github/blob/main/policies/branch-protection-sdks.yml has been removed.

Microsoft Reviewers: Open in CodeFlow

Capture current policy state so that we can make versioned changes to branch protection policies. This will enable policy history, auditing, review, standardization, and templatization. We will update policy in later PR.

We can ignore the rule that states: `At least one value under RequiredStatusChecks must be specified when RequiresStrictStatusChecks is true.` or `RequiresStrictStatusChecks must be true when specifying RequiredStatusChecks.` This is getting removed. This is getting removed.
* https://github.com/microsoft/GitOps.Branches/pull/73
* https://github.com/microsoft/GitOps.Branches/issues/72

This branch protection policy will not take effect until https://github.com/microsoftgraph/.github/blob/main/policies/branch-protection-sdks.yml has been removed.
@MIchaelMainer MIchaelMainer requested a review from a team as a code owner June 12, 2023 18:26
@Ndiritu Ndiritu merged commit 3cfadf5 into dev Jun 13, 2023
@Ndiritu Ndiritu deleted the branchprotectionpolicy branch June 13, 2023 08:37
@microsoft-github-policy-service
Copy link
Contributor

2 invalid rules

  • At least one value under RequiredStatusChecks must be specified when RequiresStrictStatusChecks is true.
  • At least one value under RequiredStatusChecks must be specified when RequiresStrictStatusChecks is true.

Total execution time: 0.03 seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants