Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update branch protection rules #1333

Merged
merged 3 commits into from
Sep 1, 2023
Merged

chore: update branch protection rules #1333

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
55c3706
chore: update branch protection rules
MIchaelMainer Aug 30, 2023
4596c30
disabled validate-pull-request required status check
MIchaelMainer Aug 31, 2023
905d875
disabled validate-pull-request required status check
MIchaelMainer Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/policies/msgraph-sdk-php-branch-protection.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ configuration:
branchProtectionRules:

- branchNamePattern: dev
# This branch pattern applies to the following branches as of 06/12/2023 10:31:17:
# This branch pattern applies to the following branches as of 08/30/2023:
# dev

# Specifies whether this branch can be deleted. boolean
Expand All @@ -33,6 +33,9 @@ configuration:
requiresConversationResolution: true
# Are merge commits prohibited from being pushed to this branch. boolean
requiresLinearHistory: false
# Required status checks to pass before merging. Values can be any string, but if the value does not correspond to any existing status check, the status check will be stuck on pending for status since nothing exists to push an actual status
requiredStatusChecks:
- validate-pull-request
MIchaelMainer marked this conversation as resolved.
Show resolved Hide resolved
# Require branches to be up to date before merging. Requires requiredStatusChecks. boolean
requiresStrictStatusChecks: true
# Indicates whether there are restrictions on who can push. boolean. Should be set with whoCanPush.
Expand All @@ -41,7 +44,7 @@ configuration:
restrictsReviewDismissals: false

- branchNamePattern: main
# This branch pattern applies to the following branches as of 06/12/2023 10:31:17:
# This branch pattern applies to the following branches as of 08/30/2023:
# main

# Specifies whether this branch can be deleted. boolean
Expand All @@ -57,13 +60,16 @@ configuration:
# Specifies the number of pull request reviews before merging. int (0-6). Should be null/empty if PRs are not required
requiredApprovingReviewsCount: 1
# Require review from Code Owners. Requires requiredApprovingReviewsCount. boolean
requireCodeOwnersReview: false
requireCodeOwnersReview: true
# Are commits required to be signed. boolean. TODO: all contributors must have commit signing on local machines.
requiresCommitSignatures: false
# Are conversations required to be resolved before merging? boolean
requiresConversationResolution: true
# Are merge commits prohibited from being pushed to this branch. boolean
requiresLinearHistory: false
# Required status checks to pass before merging. Values can be any string, but if the value does not correspond to any existing status check, the status check will be stuck on pending for status since nothing exists to push an actual status
requiredStatusChecks:
- validate-pull-request
# Require branches to be up to date before merging. Requires requiredStatusChecks. boolean
requiresStrictStatusChecks: true
# Indicates whether there are restrictions on who can push. boolean. Should be set with whoCanPush.
Expand Down