Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude *.md files from nuget package to reduce overrall package size. #566

Merged
merged 7 commits into from
Feb 25, 2021
Merged

Exclude *.md files from nuget package to reduce overrall package size. #566

merged 7 commits into from
Feb 25, 2021

Conversation

georgend
Copy link
Contributor

@georgend georgend commented Feb 22, 2021 •
edited
Loading

Exclude markdown docs from nuget package to reduce package bloat.
For package like Microsoft.Graph.Sites this reduces package size from 26MB to 14MB.
When Get-Help is called, the comment based help in the ProxyCmdletDefinitions.ps1 are used.

@georgend georgend requested a review from peombwa February 22, 2021 16:52
@georgend georgend self-assigned this Feb 22, 2021
@georgend georgend added this to the 1.4.0 milestone Feb 22, 2021
@georgend georgend linked an issue Feb 22, 2021 that may be closed by this pull request
Please reduce the size of this module bundle by eliminating documentation bloat and sharing code inside of nested modules #428
Closed
@awickham10
Copy link

Will this also remove a bunch of the comment based help bloat in the .ps1 files?

@georgend
Copy link
Contributor Author

@awickham10 That is the next issue we will tackle

peombwa
peombwa reviewed Feb 24, 2021
View reviewed changes
tools/NuspecHelper.ps1 Outdated Show resolved Hide resolved
@georgend georgend merged commit 69b79b8 into dev Feb 25, 2021
peombwa added a commit that referenced this pull request Mar 4, 2021
@peombwa @darrelmiller
@ddyett @andres-canello @github-actions @georgend
1.4.0 Release (#571)
8135056 
* Add DeviceManagement modules

* Add importedDeviceIdentity to device enrolment

* Add role management to administration

* Add device management actions and functions.

* Updated applications samples

* Added send mail sample

* Apply directive to fix wrongly named cmdlets.

* Regenerate module manifests.

* Remove *-UserAuthenticationMethod commands

* Update src/Identity.SignIns/Identity.SignIns/readme.md

Co-authored-by: Peter Ombwa <peter.ombwa@microsoft.com>

* Remove TenantId, ForceRefresh and ContextScope from AccessTokenParameterSet

* Add unit test.

* Add directive to remove Count, Keys, and Values properties from implementations of an IAssociativeArray.

* Remove new modifier for values, keys and count.

* Inline ediscovery.tag and ediscovery.sourceCollection entities.

* Cleanup previous device management modules.

* Add deviceManamenet module.

* Add deviceManagement.Action directives.

* Clean up deviceManagement directives.

* Remove ADO feeds from nuget.config.

* Remove breaking undocumented cmdlet

* Add device management profiles.

* Write generation errors to pipeline.

* Update weekly generation ADO pipeline to bump patch numbers.

* Update users.actions module directive.

* Update ADO pipeline to use the latest version of AutoREST.

* Set NODE memory to 8192.

* Set node memory in generation script.

* Clean up pipelines.

* Weekly OpenApiDocs Download (#561)

Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com>

* 1.3.2 Pre-Releases (#565)

* Add directive to remove breaking undocumented API.

* Bump all modules to 1.3.2

* Add rename directive to duplicate device management cmdlets.

* Update readme.md

* Weekly OpenApiDocs Download (#567)

Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com>

* Request Object Property Cleanup (#560)

* Remove entity-id property from entities.

* Add tests for New-MgInvitation.

* Set user type to MicrosoftGraphUser in v1.0.

* Exclude *.md files from nuget package to reduce overrall package size. (#566)

* Exclude *.md files from nuget package to reduce overrall package size.

* Exclude markdown files in weekly service module generation.

* Simplify and handle possibility of position change.

* Weekly OpenApiDocs Download (#569)

Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com>

* 1.4.0 Pre-Release (#570)

* Add no-inline for Microsoft.Graph.contentType and columnDefinition.

* Bump module version to 1.4.0

* Resolve Identity.Governance duplicate cmdlet.

Co-authored-by: Darrel Miller <darrel.miller@microsoft.com>
Co-authored-by: DeVere Dyett <ddyett@microsoft.com>
Co-authored-by: Andres Canello [Microsoft] <39328890+andres-canello@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com>
Co-authored-by: George <1641829+finsharp@users.noreply.github.com>
peombwa added a commit that referenced this pull request Mar 10, 2021
@peombwa @darrelmiller
@ddyett @andres-canello @github-actions @georgend
1.4.0 Release (#571)
8059a77 
* Add DeviceManagement modules

* Add importedDeviceIdentity to device enrolment

* Add role management to administration

* Add device management actions and functions.

* Updated applications samples

* Added send mail sample

* Apply directive to fix wrongly named cmdlets.

* Regenerate module manifests.

* Remove *-UserAuthenticationMethod commands

* Update src/Identity.SignIns/Identity.SignIns/readme.md

Co-authored-by: Peter Ombwa <peter.ombwa@microsoft.com>

* Remove TenantId, ForceRefresh and ContextScope from AccessTokenParameterSet

* Add unit test.

* Add directive to remove Count, Keys, and Values properties from implementations of an IAssociativeArray.

* Remove new modifier for values, keys and count.

* Inline ediscovery.tag and ediscovery.sourceCollection entities.

* Cleanup previous device management modules.

* Add deviceManamenet module.

* Add deviceManagement.Action directives.

* Clean up deviceManagement directives.

* Remove ADO feeds from nuget.config.

* Remove breaking undocumented cmdlet

* Add device management profiles.

* Write generation errors to pipeline.

* Update weekly generation ADO pipeline to bump patch numbers.

* Update users.actions module directive.

* Update ADO pipeline to use the latest version of AutoREST.

* Set NODE memory to 8192.

* Set node memory in generation script.

* Clean up pipelines.

* Weekly OpenApiDocs Download (#561)

Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com>

* 1.3.2 Pre-Releases (#565)

* Add directive to remove breaking undocumented API.

* Bump all modules to 1.3.2

* Add rename directive to duplicate device management cmdlets.

* Update readme.md

* Weekly OpenApiDocs Download (#567)

Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com>

* Request Object Property Cleanup (#560)

* Remove entity-id property from entities.

* Add tests for New-MgInvitation.

* Set user type to MicrosoftGraphUser in v1.0.

* Exclude *.md files from nuget package to reduce overrall package size. (#566)

* Exclude *.md files from nuget package to reduce overrall package size.

* Exclude markdown files in weekly service module generation.

* Simplify and handle possibility of position change.

* Weekly OpenApiDocs Download (#569)

Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com>

* 1.4.0 Pre-Release (#570)

* Add no-inline for Microsoft.Graph.contentType and columnDefinition.

* Bump module version to 1.4.0

* Resolve Identity.Governance duplicate cmdlet.

Co-authored-by: Darrel Miller <darrel.miller@microsoft.com>
Co-authored-by: DeVere Dyett <ddyett@microsoft.com>
Co-authored-by: Andres Canello [Microsoft] <39328890+andres-canello@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com>
Co-authored-by: George <1641829+finsharp@users.noreply.github.com>
peombwa added a commit that referenced this pull request Mar 11, 2021
@peombwa @darrelmiller
@ddyett @andres-canello @github-actions @georgend
1.4.0 Release (#571) (#580)
5a5ee61 
* Add DeviceManagement modules

* Add importedDeviceIdentity to device enrolment

* Add role management to administration

* Add device management actions and functions.

* Updated applications samples

* Added send mail sample

* Apply directive to fix wrongly named cmdlets.

* Regenerate module manifests.

* Remove *-UserAuthenticationMethod commands

* Update src/Identity.SignIns/Identity.SignIns/readme.md

Co-authored-by: Peter Ombwa <peter.ombwa@microsoft.com>

* Remove TenantId, ForceRefresh and ContextScope from AccessTokenParameterSet

* Add unit test.

* Add directive to remove Count, Keys, and Values properties from implementations of an IAssociativeArray.

* Remove new modifier for values, keys and count.

* Inline ediscovery.tag and ediscovery.sourceCollection entities.

* Cleanup previous device management modules.

* Add deviceManamenet module.

* Add deviceManagement.Action directives.

* Clean up deviceManagement directives.

* Remove ADO feeds from nuget.config.

* Remove breaking undocumented cmdlet

* Add device management profiles.

* Write generation errors to pipeline.

* Update weekly generation ADO pipeline to bump patch numbers.

* Update users.actions module directive.

* Update ADO pipeline to use the latest version of AutoREST.

* Set NODE memory to 8192.

* Set node memory in generation script.

* Clean up pipelines.

* Weekly OpenApiDocs Download (#561)

Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com>

* 1.3.2 Pre-Releases (#565)

* Add directive to remove breaking undocumented API.

* Bump all modules to 1.3.2

* Add rename directive to duplicate device management cmdlets.

* Update readme.md

* Weekly OpenApiDocs Download (#567)

Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com>

* Request Object Property Cleanup (#560)

* Remove entity-id property from entities.

* Add tests for New-MgInvitation.

* Set user type to MicrosoftGraphUser in v1.0.

* Exclude *.md files from nuget package to reduce overrall package size. (#566)

* Exclude *.md files from nuget package to reduce overrall package size.

* Exclude markdown files in weekly service module generation.

* Simplify and handle possibility of position change.

* Weekly OpenApiDocs Download (#569)

Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com>

* 1.4.0 Pre-Release (#570)

* Add no-inline for Microsoft.Graph.contentType and columnDefinition.

* Bump module version to 1.4.0

* Resolve Identity.Governance duplicate cmdlet.

Co-authored-by: Darrel Miller <darrel.miller@microsoft.com>
Co-authored-by: DeVere Dyett <ddyett@microsoft.com>
Co-authored-by: Andres Canello [Microsoft] <39328890+andres-canello@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com>
Co-authored-by: George <1641829+finsharp@users.noreply.github.com>

Co-authored-by: Darrel Miller <darrel.miller@microsoft.com>
Co-authored-by: DeVere Dyett <ddyett@microsoft.com>
Co-authored-by: Andres Canello [Microsoft] <39328890+andres-canello@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com>
Co-authored-by: George <1641829+finsharp@users.noreply.github.com>
@georgend georgend deleted the features/excludemdfiles branch March 11, 2021 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peombwa peombwa peombwa approved these changes

@ddyett ddyett ddyett approved these changes

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

Assignees

@georgend georgend

Labels
None yet
Projects
None yet
Milestone
1.4.0
4 participants
@georgend @awickham10 @peombwa @ddyett